Problem/Motivation

Symfony has added return types to Symfony\Component\HttpKernel\Controller\ArgumentValueResolverInterface:

    public function supports(Request $request, ArgumentMetadata $argument): bool;

    public function resolve(Request $request, ArgumentMetadata $argument): iterable;

We need to do the same for compatibility with Symfony 6.

Steps to reproduce

Proposed resolution

Add the return types.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3259028-2.patch2.01 KBlongwave

Comments

longwave created an issue. See original summary.

longwave’s picture

Status: Active » Needs review
StatusFileSize
new2.01 KB
daffie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me.

  • catch committed 375f5f2 on 10.0.x
    Issue #3259028 by longwave: [Symfony 6] Add return types to Symfony\...
catch’s picture

Version: 9.4.x-dev » 10.0.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 375f5f2 and pushed to 10.0.x. Thanks! Also linked it from the bumper change record.

I think we probably only want this in 10.x, although likelihood of anyone extending in 9.4.x also seems low.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.