Problem/Motivation

In Symfony 6, return types have been added to methods in Symfony\Component\Console\Application:

  protected function getCommandName(InputInterface $input): ?string {

  protected function getDefaultCommands(): array {

  public function getDefinition(): InputDefinition {

We need to add these for our applications to work on Symfony 6.

Steps to reproduce

Proposed resolution

Add the return types.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comments

longwave created an issue. See original summary.

longwave’s picture

Status: Active » Needs review
StatusFileSize
new4.16 KB
longwave’s picture

StatusFileSize
new4.16 KB
new611 bytes

Fix typo spotted by @daffie in the parent issue.

longwave’s picture

Title: [Symfony 6] Add type hints to Symfony Console applications » [Symfony 6] Add return types to Symfony Console application methods
Issue summary: View changes

The last submitted patch, 2: 3259026-2.patch, failed testing. View results

daffie’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me.

  • catch committed aeb1563 on 10.0.x
    Issue #3259026 by longwave, daffie: [Symfony 6] Add return types to...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed aeb1563 and pushed to 10.0.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.