Problem/Motivation
Right now the TYPE column shows Custom or Contributed but does not show if the extension is a module, theme, or profile. It would be useful to know this, especially when we are working on a site we are not familiar with.
Steps to reproduce
Run report and look at the TYPE column.
Proposed resolution
Tack on the $extension->getType() to the existing type so it looks like:
- Contributed module
- Contributed profile
- Contributed theme
- Custom module
- Custom profile
- Custom theme
Remaining tasks
- Create patch
- Review and test patch
- Commit it :)
User interface changes
The extension type will show up in the report.
API changes
Data model changes
Comments
Comment #2
hmendes commentedSending a patch.
Comment #3
gábor hojtsyThanks! This does not seem to support translation for the type name? I suspect it would look a bit less orderly to support translation, but it would be worth it IMHO.
Comment #4
hmendes commentedHow should the code be? From the examples I saw in other modules people were just using
$this->t('Something @label.', ['@label' => $something])Comment #5
gábor hojtsyI think for this case, we would need to
t()all the combinationst('Custom module'), etc. probably in an if/else or switch/case.Comment #6
hmendes commentedSomething like this?
I didn't understand why we need to do this in this case... Can you explain?
Comment #7
gábor hojtsyIf we don't translate the type names, it would end up with the first parts translated and the second parts untranslated.
Comment #9
gábor hojtsyThanks! Committed and will be part of the next release :)