Problem/Motivation

The visually hidden text describing a toolbar buttons purpose has unnecessary parentheses and curly braces at the end. The screen readers I tested include the curly brace in their announcement, so this is more than cosmetic

Steps to reproduce

Proposed resolution

Remove that punctuation.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#6 3258668-6-d10.patch1.46 KBbnjmnm
Screen Shot 2022-01-14 at 2.15.57 PM.png100.03 KBbnjmnm

Issue fork drupal-3258668

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bnjmnm created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Wow, what a find! 😅

If this is Major, should it also be a stable blocker? 🤔

bnjmnm opened merge request !1672

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Reviewed & tested by the community
Issue tags: +JavaScript

FYI: this fix is also present in #3218297, see #3218297-9: Voiceover + Safari reads aria-describedby twice when focusing toolbar button.

I'm fine with this going in as-is (hence RTBC) or for this to get marked as a duplicate of that one. I'll let @bnjmnm and @lauriii decide.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented

Would it be possible to get a patch for Drupal 10? 🙏

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
StatusFileSize
new 3258668-6-d10.patch1.46 KB

D10 patch attached.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented

This looks good! This can be committed after the freeze 👍

  • lauriii committed 9a98b09 on 10.0.x 
    Issue #3258668 by bnjmnm, Wim Leers: Extraneous closing parentheses and...

lauriii closed merge request !1672

  • lauriii committed 5ffec8b on 9.4.x 
    Issue #3258668 by bnjmnm, Wim Leers: Extraneous closing parentheses and...

  • lauriii committed f7f365d on 9.3.x 
    Issue #3258668 by bnjmnm, Wim Leers: Extraneous closing parentheses and...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 9.4.x-dev » 9.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed 9a98b09 and pushed to 10.0.x. Committed the MR in 9.4.x and cherry-picked to 9.3.x because CKEditor 5 is experimental, and this is a low risk change. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.