Problem/Motivation

@bnjmnm did a deep round of review in #3206687: Toolbar UI accessibility review.

But after #3227853: Remove dependency on Vue.js, we need a new round of accessibility testing — @lauriii paid close attention to mimic the old behavior as close as possible, but … rather safe than sorry! 🤓😊

Steps to reproduce

Proposed resolution

Remaining tasks

Issues

User interface changes

API changes

Data model changes

Comments

Wim Leers created an issue. See original summary.

Wim Leers credited bnjmnm.

Wim Leers credited lauriii.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Project: CKEditor 5 » Drupal core
Version: 1.0.x-dev » 9.3.x-dev
Component: User interface » ckeditor5.module

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Issue summary: View changes
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue summary: View changes

#3258668: Extraneous closing parentheses and curly brace in visually-hidden button description text landed 👍

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

With #3231321: Improve keyboard accessibility in a particular edge case and #3258030: Text fields using CKEditor 5 do not get visual error indicator done, I think pushing this forward now probably makes sense? :)

bnjmnm’s picture

bnjmnm
he/him
Primary language English
Location Ann Arbor, MI
commented
Issue summary: View changes
Status: Active » Fixed

Much of the findings in the initial review at #3206687: Toolbar UI accessibility review are still valid. The overall semantics of the Toolbar UI are significantly better, and the AT support is as good or better than CKEditor 4.

I found several new issues, some of which are stable blockers. Everything I found was filed as a new issue and added to the issue summary. Here's basically what I checked:

  • OSX Voiceover / Windows NVDA screenreader review
  • Using the rotors of the above screenreaders, confirming the reported elements were as good or better.
  • High contrast mode review with Firefox and Edge, using the default high contrast theme

This round of review is closed, and of course this doesn't suddenly mean CKEditor 5 toolbar 100% accessible it is perfect. Several important issues were found and added to the stable roadmap as needed. This round of review is over and I'm going to stop this from becoming a stale evergreen meta.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.