Preselect doesn't work with autocomplete field.

Here is a patch to fix this issue. I added @EntityReferenceSelection plugin for support preselect options for the autocomplete field widget.

Thank you, the patch works flawlessly.

Apologies for missing this. I am just a bit nervous that this is risky as it seems quite likely that there may be cases where site editors have selected a View they are not allowed to select according to 'Preselect View Options'. I suppose it won't break things BUT it would then prevent resave e.g. of a node or paragraph.

Beyond that we just need test coverage + conversion to merge request to get this in.

Needs also coordination in case #2922687: Allow inclusion of views by administrative tag(s) in select widget. is merged first to also add that restriction to autocomplete (could also be a separate follow-up issue though)

It might be safer to move the configuration for this feature, to the field widget settings for the select widget. This approach would ensure that existing widgets (currently only the Select widget) continue to function properly while introducing this as a new option for the Autocomplete widget.

What are your thoughts?

Hmmm it's a good suggestion.

I guess my worry is that choosing which views are available is probably comparably essential as choosing a vocabulary with a taxonomy reference field and DX might suffer hiding it.

Might anyways be simpler to add support for autocomplete then to handle the update hooks.

I've added a proof of concept as Merge Request !82 for your consideration.

The merge request:
- Incorporates the patch from #2 but uses widget settings instead of field settings.
- Has an update function to move values from field config to field widget config
- Adds widget settings for both the select element and the autocomplete widget.

Hmmm yeah I see how it would work, and thank you for spending the time on it. I think its a fairly big DX change though and I still worry about it then being more hidden.

Are there other features you feel are specific to the Select widget that justify the separation of controls from autocomplete vs select? Otherwise I can try to insist that any future new feature covers both, allowing us to keep the settings in the field settings (e.g. in #2922687: Allow inclusion of views by administrative tag(s) in select widget.)

If we do ultimately go down this route, we can sign-post that more controls can be found in the manage form display, but let's not do that yet until we get more of a direction decision (which I am not convinced is needed yet). If we are at a stalemate I can reach out to other maintainers in Drupal Slack to get opinions. Sorry - just nervous as its a very heavily used module

For anyone else reviewing, updated screenshot:

Manage form display with proposed change:

Manage field settings with proposed change:

FWIW:

1. I think for the sake of fixing the bug we should get autocomplete to match select like the patch in #2 starts but then also needs tests as per #4.
2. Then we can move the wider DX change to a follow-up to deal with it in isolation from the bug.

I've converted the patch in #2 to a merge request.

This seems to work, however, now the existing PHPUnit tests are failing.

There was 1 failure:
1) Drupal\Tests\viewsreference\FunctionalJavascript\ViewsReferenceFieldTest::testCreateViewsReferenceField
Behat\Mink\Exception\ElementNotFoundException: Option with id|name|label|value "block_1" not found.
/builds/issue/viewsreference-3257767/web/core/tests/Drupal/Tests/WebAssert.php:240
/builds/issue/viewsreference-3257767/tests/src/FunctionalJavascript/ViewsReferenceFieldTest.php:107
ERRORS!
Tests: 15, Assertions: 141, Errors: 1, Failures: 1, Skipped: 1.

See https://git.drupalcode.org/project/viewsreference/-/blob/8.x-2.x/tests/s...

Thanks for all the work on this! Fixed it up a bit + added new test coverage that fails before this code and passes after.

Hid the managed form display branch just to avoid future confusion (not delete of course in case ever revisiting UX).

Running out of time this morning but hopefully that will resolve the test coverage. Could use a check from one of us here again to get an RTBC if so. Thanks!

Pipeline green now yeah

Thanks for the back and forth on this. The DX change to manage form display can be a follow-up, will leave the branch in case its ever useful; but good to actually fix the issue itself here.