First of all. Thanks for maintaining this module
Currently in the process of switching from the deprecated Swift Mailer module replaced by Symfony Mailer

Problem/Motivation

The Symfony Mailer's composer.json file look like:

{
  "name": "drupal/symfony-mailer",
  "description": "Symfony Mailer",
  "type": "drupal-module",
  "license": "GPL-2.0-or-later",
  "require": {
    "html2text/html2text": "^4.0.1",
    "symfony/mailer": "^5.3.0",
    "tijsverkoyen/css-to-inline-styles": "^2.2"
  }
}

Proposed resolution

Change "name": "drupal/symfony-mailer", to "name": "drupal/symfony_mailer",

Remaining tasks

  • Fix patch/MR
  • Review
  • Commit
  • Release

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

RajabNatshah created an issue. See original summary.

rajab natshah’s picture

Assigned: rajab natshah » Unassigned
Status: Active » Needs review
adamps’s picture

Hi @RajabNatshah thanks for the issue. I see your point, it seems like it ought to be an underscore. However I don't see any problems

Before we change this I would like to check:

  1. What are the symptoms - what problem or error messages does this cause?
  2. What will happen to existing sites if we change it? If they have drupal/symfony-mailer in their composer.json would they break?
rajab natshah’s picture

Thanks, Adam for following up on the issue

Probably only for standard and better practice.

The fallback package from the symfony_mailer.info.yml will work and get the package from packages.drupal.org
I guess the packages.drupal.org repository is reading the composer.json at this time. Not sure if that will affect autoloading with namespaces or classes maps.

Same for the 1.x branch to work with Semantic Versioning.
It's working

Only for a better practice to have 1.0.x as the branch to match with MAJOR.MINOR.PATCH
so the composer could get the 1.0.x-dev version or the 1.0.0 stable version
Then a new work for a big minor improvement or change to have the 1.1.x branch and then 1.1.0 stable.

adamps’s picture

Status: Needs review » Fixed

Thanks that sounds pretty safe. The branch version has a separate issue already: #3229697: Fix branch name conforming to semver

  • AdamPS committed 47977cc on 1.x authored by Rajab Natshah
    Issue #3257731 by Rajab Natshah, AdamPS: Fix composer.json file for the...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.