Closed (fixed)
Project:
Mailer Plus (DSM+)
Version:
1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Jan 2022 at 10:39 UTC
Updated:
1 Feb 2022 at 15:04 UTC
Jump to comment: Most recent
First of all. Thanks for maintaining this module
Currently in the process of switching from the deprecated Swift Mailer module replaced by Symfony Mailer
The Symfony Mailer's composer.json file look like:
{
"name": "drupal/symfony-mailer",
"description": "Symfony Mailer",
"type": "drupal-module",
"license": "GPL-2.0-or-later",
"require": {
"html2text/html2text": "^4.0.1",
"symfony/mailer": "^5.3.0",
"tijsverkoyen/css-to-inline-styles": "^2.2"
}
}
Change "name": "drupal/symfony-mailer", to "name": "drupal/symfony_mailer",
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
rajab natshahComment #4
adamps commentedHi @RajabNatshah thanks for the issue. I see your point, it seems like it ought to be an underscore. However I don't see any problems
Before we change this I would like to check:
Comment #5
rajab natshahThanks, Adam for following up on the issue
Probably only for standard and better practice.
The fallback package from the
symfony_mailer.info.ymlwill work and get the package from packages.drupal.orgI guess the packages.drupal.org repository is reading the
composer.jsonat this time. Not sure if that will affect autoloading with namespaces or classes maps.Same for the 1.x branch to work with Semantic Versioning.
It's working
Only for a better practice to have 1.0.x as the branch to match with MAJOR.MINOR.PATCH
so the composer could get the 1.0.x-dev version or the 1.0.0 stable version
Then a new work for a big minor improvement or change to have the 1.1.x branch and then 1.1.0 stable.
Comment #6
adamps commentedThanks that sounds pretty safe. The branch version has a separate issue already: #3229697: Fix branch name conforming to semver