Problem/Motivation

No term selected. WSOD with error Error: Call to a member function bundle() on null

Steps to reproduce

Select no term WSOD

Proposed resolution

The same solution as on https://www.drupal.org/project/mixitup_views/issues/3040522
Line 445 OptionsShsWidget.php

if (!empty($term)) {
               $vid = $term->bundle();
               }

I am not enough programmer to build patch sorry.

Remaining tasks

User interface changes

API changes

Data model changes

Greetings, Martijn

CommentFileSizeAuthor
#6 2022-01-12--3257269--shs-2.0.x-dev--parse-term-bundle-2.patch812 bytesmr.valters
#5 2022-01-12--3257269--shs-2.0.x-dev--parse-term-bundle.patch811 bytesmr.valters

Comments

Summit created an issue. See original summary.

tmaiochi’s picture

tmaiochi commented
Assigned: Unassigned » tmaiochi

I'll work on this.

tmaiochi’s picture

tmaiochi commented
Assigned: tmaiochi » Unassigned

Sorry, but I can't reproduce this error. Can you give me more details, please?

summit’s picture

summit commented

Hi,
Sorry, I try to reproduce it myself.
I need functionality like:
https://www.drupal.org/project/shs/issues/2712115 for new terms and
https://www.drupal.org/project/shs/issues/3248983 for term lineage.
And I think some of this code was interfering.

Now I have implemented clean latest .dev and patch from https://www.drupal.org/project/shs/issues/3241169
Now it works without being able to add new terms on node edit and without the term lineage. No WSOD anymoe.
But not this functionality also..

May be a check like I propose easy and may be not, I am not able to judge about that.
greetings and thanks for your quick reply, Martijn

mr.valters’s picture

mr.valters
Location Georgia
commented
StatusFileSize
new 2022-01-12--3257269--shs-2.0.x-dev--parse-term-bundle.patch811 bytes
mr.valters’s picture

mr.valters
Location Georgia
commented
StatusFileSize
new 2022-01-12--3257269--shs-2.0.x-dev--parse-term-bundle-2.patch812 bytes
joel_osc’s picture

joel_osc commented
Status: Active » Needs review

+1 for RBTC - patch fixed this error which was triggered when adding a paragraph to a node with an SHS field on it. Thank-you @mr.valters!

stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Needs review » Active
Related issues: +#3241169: Error saving null/empty value after 2.0.0-rc1 update

This has probably been fixed with #3241169: Error saving null/empty value after 2.0.0-rc1 update but I'm extending the checks here.

stborchert’s picture

stborchert
he/him
Primary language German
commented
Status: Active » Fixed

  • mr.valters authored 00a31ec on 2.0.x 
    Issue #3257269 by mr.valters, Summit, stBorchert: Error: Call to a...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.