Drupal 9.3 was just released, versions 8.9, 9.0 and 9.1 are no longer supported. We should threfore increase our Core version dependency to 9.2.
While we’re at it, we should probably also include version 10 in our core_version_requirement statements.

CommentFileSizeAuthor
#8 3256028-8--drupal_9_2_dependency.patch11.23 KBdrunken monkey
#8 3256028-8--drupal_9_2_dependency--interdiff.txt446 bytesdrunken monkey
#6 3256028-6--drupal_9_2_dependency.patch11.19 KBdrunken monkey

Issue fork search_api-3256028

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

drunken monkey created an issue. See original summary.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented

I already did that for search_api_solr and facets. And yes, please include 10.0.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Issue summary: View changes

Thanks for the feedback!

Regarding the last line from the IS:

Finally, we can then also switch the “on commit” tests to use Drupal 10.x (instead of, currently, 9.4).

I now remembered that this isn’t possible due to deprecations being removed (same as for 9.x), so we’ll need to keep this at the latest 9.x version until we depend on the last 9.x minor release.

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented

BTW shouldn't we switch to semantic versioning? 8.x-1.x sounds strange if Drupal 8 is not supported anymore.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

I think the 2.0.0 release will be a larger affair, with removals of deprecated code and potentially other breaking changes, so I think we should take our time with that one to plan it more carefully.
In general, though, I agree of course: I’d love to move to semver, and having the 8.x-* prefix is indeed a bit confusing at this point. (Looking at the most popular contrib projects, though, it seems we’re in excellent company there.)

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 3256028-6--drupal_9_2_dependency.patch11.19 KB

This should do it.

Status: Needs review » Needs work

The last submitted patch, 6: 3256028-6--drupal_9_2_dependency.patch, failed testing. View results

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Needs review
StatusFileSize
new 3256028-8--drupal_9_2_dependency--interdiff.txt446 bytes
new 3256028-8--drupal_9_2_dependency.patch11.23 KB
mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Needs review » Reviewed & tested by the community

chr.fritsch made their first commit to this issue’s fork.

chr.fritsch opened merge request !34

  • drunken monkey committed eccf883 on 8.x-1.x 
    Issue #3256028 by drunken monkey, mkalkbrenner:  Increased Core version...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks again!

@ chr.fritsch: Please create a new issue for that – and maybe explain at least with a single sentence what you’re doing. Just throwing a patch into an issue seems a bit rude. (Also, until #3190024: Problem with test dependencies when testing issue forks gets finally fixed (ETA: never), please don’t use issue forks in this project.)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.