Problem/Motivation

Download codemirror library in the right directory and see that the codemirror element won't work as expected.

Steps to reproduce

1) Create a webform with a codemirror element.
2) Check the webform and see that it works.
3) Download codemirror library.
4) Check the element won't display properly anymore.

CommentFileSizeAuthor
#10 3254993-10.patch430 bytesjrockowitz
#5 Screen Shot 2021-12-21 at 7.25.30 AM.png288.82 KBjrockowitz
#4 Screenshot from 2021-12-21 08-36-01.png107.25 KBpaulocs

Comments

paulocs created an issue. See original summary.

jrockowitz’s picture

jrockowitz commented
Status: Active » Postponed (maintainer needs more info)

I am not able to reproduce this issue.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Postponed (maintainer needs more info) » Active

That is the error I get when I download https://github.com/codemirror/CodeMirror/releases/tag/5.61.1 library.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
StatusFileSize
new Screenshot from 2021-12-21 08-36-01.png107.25 KB
jrockowitz’s picture

jrockowitz commented
Issue summary: View changes
StatusFileSize
new Screen Shot 2021-12-21 at 7.25.30 AM.png288.82 KB

I am not able to reproduce this issue. Can you look and confirm the file does not exist?

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented

Am I downloading the library from the right link? https://github.com/codemirror/CodeMirror/releases/tag/5.61.1

Do I have to download anything else?

Because if you check the lib folder in the repo tag page, it does not have the codemirror.js file. See: https://github.com/codemirror/CodeMirror/tree/5.61.1/lib.

jrockowitz’s picture

jrockowitz commented

When I download https://github.com/components/codemirror/archive/5.61.1.zip it container the lib/codemirror.js file. Later versions are missing the file.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented

aaah, I'm downloading from the wrong repository....

In webform.libraries.yml, the repository is: https://github.com/codemirror/codemirror
See:

libraries.codemirror.text:
  remote: https://github.com/codemirror/codemirror
  version: &webform_codemirror_version '5.61.1'
  license: &webform_codemirror_license
    name: MIT
    url: http://codemirror.net/LICENSE
    gpl-compatible: true
  directory: &webform_codemirror_directory codemirror
  cdn: &webform_codemirror_cdn
    /libraries/codemirror/lib/: https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.61.1/
    /libraries/codemirror/: https://cdnjs.cloudflare.com/ajax/libs/codemirror/5.61.1/
  css:
    component:
      /libraries/codemirror/lib/codemirror.css: {}
  js:
    /libraries/codemirror/lib/codemirror.js: { weight: -1 }
    /libraries/codemirror/addon/runmode/runmode.js: {}
    /libraries/codemirror/addon/display/placeholder.js: {}

Shouldn't it be remote: https://github.com/components/codemirror?

jrockowitz’s picture

jrockowitz commented

@see https://github.com/codemirror/CodeMirror/issues/6698

jrockowitz’s picture

jrockowitz commented
Status: Active » Needs review
StatusFileSize
new 3254993-10.patch430 bytes

The best compromise is to add a download property to the webform.libraries.yml definition.

paulocs’s picture

paulocs
Primary language Portuguese, Brazil
Location Belo Horizonte
commented
Status: Needs review » Reviewed & tested by the community

Makes sense. Thanks a lot @jrockowitz

  • jrockowitz authored 30a5abd on 6.x 
    Issue #3254993 by jrockowitz, paulocs: Codemirror does not work when the...

  • jrockowitz authored 30a5abd on 6.1.x 
    Issue #3254993 by jrockowitz, paulocs: Codemirror does not work when the...
jrockowitz’s picture

jrockowitz commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.