Hello all, it’s time for the weekly migration subsystem meeting. The meeting will take place in slack in various threads
This meeting:
➤ Is for core migrate maintainers and developers and anybody else in the community with an interest in migrations
➤ Usually happens every Thursday and alternates between 1400 and 2100 UTC.
➤ Is done on the #migration channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to. See the parent issue for an idea of the typical agenda.
➤*Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

Core migration issues

Next video meeting 2022-13-01 2100Z

The hope is that most or all of the maintainers will attend. We will try to focus on longer-term goals than in the weekly meeting.

0️⃣ Who is here today? What would be a good icebreaking question for future meetings?

dinarcon :wave: Hi
quietone Hi.
jibran hi!
quietone How can I choose just one question?
Matroskeen Hello from Ukraine
damienmckenna "What was your biggest surprise change notice, i.e. a change notice you didn't know about and was a huge surprise when you found out about it?" (-:

1️⃣ What should we talk about today? Suggest topics here and I will add threads. I will also check for comments on the issue for today’s meeting.

dinarcon Yesterday there was a request for a new release of Migrate Tools https://drupal.slack.com/archives/C226VLXBP/p1639567118460700
Matroskeen [#3069776]Do you think we can land this in 9.4 if we pay a little more attention to it?Just wondering if it's worth putting some effort to it at this point (edited)
damienmckenna Any thoughts on the future of Migrate Commerce? It's falling out of sync with core and almost needs a new branch for each core release due to changes in the testing system.
damienmckenna There's some WIP in #3253893: Update codebase to be fully compatible with Drupal core 9.3.x but it needs more work. (edited)

2️⃣ Action items. To be added later.

3️⃣ Statistics

mikelutz (he/him) NR 31, 2 major, 2 over 3 months old
mikelutz (he/him) RTBC 13, 6 older than a month
mikelutz (he/him) Fixed since last meeting - 1 Minor
mikelutz (he/him) https://docs.google.com/spreadsheets/d/1o0Rjlc1vnnLP5bM5P-SMMyGzqn7258hi...
quietone I do like that there are < 400 open migration system issue. (edited)
quietone When it is over 400, my head hurts.
quietone Speaking for myself, I've been emphasizing doing reviews and it look like that is helping, there were 43 at NR in late October and now there are 32.

4️⃣ Comment in this thread if you are looking for ways to help. Give us some idea of what you would like to do: documentation, code review, testing, project management, ...

5️⃣ Previous minutes

mikelutz (he/him) #3252697: [meeting] Migrate Meeting 2021-12-09 1400Z
quietone I forgot to do the minutes for 2021-11-11 until last week, so they should be checked as well.  #3247998: [meeting] Migrate Meeting 2021-11-11 1400Z

6️⃣ New Release of Migrate Tools

mikelutz (he/him) @heddn? Are they asking about a new 4.x release compatible with Drush 9?  I don’t recall where we ended with drush stuff.
damienmckenna Shouldn't folks on D9 move to the 8.x-5.x branch?

7️⃣ Deprecate Migration::set()

mikelutz (he/him) #2796755: [PP-1] Deprecate Migration::set()
quietone Responded to feedback from last week and back to passing tests. If anything, should be closed to RTBC
quietone Asked in #contribute for a review.

8️⃣ Mark an entity as syncing during update

mikelutz (he/him) #3052115: Mark an entity as 'syncing' during a migration update
jibran What is the discussion point here?
mikelutz (he/him) I’m not familiar with this one, but it’s tagged major but hasn’t been touched in 3 weeks, which makes for good meeting fodder.
mikelutz (he/him) So the discussion is can we touch it in some way to move it forward or otherwise close the ticket.
mikelutz (he/him) At a glance, it’s marked needs review, but the description says it’s blocked on another issue that is NW, so something isn’t right here.
jibran I don't think closing it makes sense. We should fix it but at the same time other modules should add checks for this as well. e.g. search_api should not index the entity if it is syncing.
quietone The IS says that the changed timestamp is the request time stamp. That does not match what the migration tests actually test.
quietone It reads like a feature request to me, not a task.
quietone The IS needs an update. What is the justification for this feature.
mikelutz (he/him) Yeah, let change that and set the priority back to normal. I see this is not actually major.
mikelutz (he/him) The person who set it to major has a habit of setting issues to major that are not major.
quietone Is this something we want to implement?
mikelutz (he/him) I don't know. My guess is there's something worth doing here, but I don't have time to fully read through and understand it at this second. Let's tag it for subsystem maintainer review too so it doesn't slip by us without giving us a chance to make sure there isn't any other concequences they aren't thinking of.

9️⃣ Allow defining conditions and join in SQL source plugins

mikelutz (he/him) #3069776: SQL source plugins: allow defining conditions and join in migration yml
Matroskeen I like this feature and would like to see it in core since 9.4.0. Does anyone want to help? :slightly_smiling_face:I hope we also have an approval from Migrate maintainers, although it doesn't have usage in core yet...
Matroskeen It could be possible to use this in core if we had a source for SQL table. Then we could get rid of many simple plugins with plain select query (edited)
mikelutz (he/him) Yeah, the dream goal is to go from what we have now, which is a SqlBase class that basically has to be extended for every use case with a custom query() method, to a generic SqlBase that can have the query (really the info needed for query builder parameters) specified in the migration yml so we can reduce the number of custom source plugins that need to be built for common tasks.
quietone If we want this in core, I would like to see more testing. I'd like to see some Kernal Migration tests that use the various new features. And ideally feedback from manual testing.

🔟 Commerce Migrate (edited) 

quietone I presume you mean Commerce Migrate?
quietone The best way to get action there is to talk to me in #migration
quietone I have been trying to get to it for the past 3 weeks. The spirit is willing .....
damienmckenna IKWYM.

1️⃣1️⃣ Wrap up

mikelutz (he/him) Thanks all! see you next week!
quietone @mikelutz (he/him) Thanks!

Comments

quietone created an issue. See original summary.

quietone credited DamienMcKenna.

quietone credited Matroskeen.

quietone credited jibran.

quietone credited mikelutz.

quietone’s picture

quietone commented
Issue summary: View changes
quietone’s picture

quietone commented
Status: Needs review » Fixed

There we no requests for changes to these minutes, closing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.