There were some incremental changes in Drupal 9.3. This is to fix the failing tests and set the minimum Drupal version to 9.3

CommentFileSizeAuthor
#18 3253893-18.patch5.02 KBquietone
#18 interdiff-16-18.txt679 bytesquietone
#16 3253893-16.patch4.18 KBquietone
#15 3253893-15.patch9.19 KBquietone
#15 interdiff.txt3.04 KBquietone
#13 3253893-13.patch27.34 KBquietone
#13 interdiff.txt1.11 KBquietone
#9 commerce_migrate-n3253893-9.patch5.18 KBdamienmckenna
#9 commerce_migrate-n3253893-9.interdiff.txt835 bytesdamienmckenna
#7 commerce_migrate-n3253893-7.interdiff.txt2.06 KBdamienmckenna
#7 commerce_migrate-n3253893-7.patch5.63 KBdamienmckenna
#4 commerce_migrate-n3253893-4.interdiff.txt4.24 KBdamienmckenna
#4 commerce_migrate-n3253893-4.patch4.64 KBdamienmckenna
#2 commerce_migrate-n3253893-2.patch410 bytesdamienmckenna

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new commerce_migrate-n3253893-2.patch410 bytes

Starting with a placeholder change.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Priority: Normal » Major

Will work on this tomorrow, unless someone else wants to take a look.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new commerce_migrate-n3253893-4.patch4.64 KB
new commerce_migrate-n3253893-4.interdiff.txt4.24 KB

This patch contains two types of changes - the getEntityCounts() methods were updated for changes in core, and the getMissingPaths() methods had 'Token' removed; I'm not sure why that last change is necessary.

Status: Needs review » Needs work

The last submitted patch, 4: commerce_migrate-n3253893-4.patch, failed testing. View results

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Need to run one of the MigrateUpgradeReviewPageTest tests locally so I can see what the difference is.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new commerce_migrate-n3253893-7.patch5.63 KB
new commerce_migrate-n3253893-7.interdiff.txt2.06 KB

I hope this resolves the MigrateUpgradeReviewPageTest tests.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

There are also some deprecation notices:

  1x: drupal_get_path() is deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. Use \Drupal\Core\Extension\ExtensionPathResolver::getPath() instead. See https://www.drupal.org/node/2940438
    1x in MigrateUpgradeReviewPageTest::testMigrateUpgradeReviewPage from Drupal\Tests\commerce_migrate_ubercart\Functional\uc7

  1x: drupal_get_filename() is deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. Use \Drupal\Core\Extension\ExtensionPathResolver::getPathname() instead. See https://www.drupal.org/node/2940438
    1x in MigrateUpgradeReviewPageTest::testMigrateUpgradeReviewPage from Drupal\Tests\commerce_migrate_ubercart\Functional\uc7

(and similar ones in other tests)

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Related issues: +#3189605: Declare upgrade status from D6, D7
StatusFileSize
new commerce_migrate-n3253893-9.interdiff.txt835 bytes
new commerce_migrate-n3253893-9.patch5.18 KB

Locally I noticed that #3189605: Declare upgrade status from D6, D7 caused test failures, but I need to undo that for now.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

Down to ten test failures.

junaidpv’s picture

junaidpv
Location Kannur, Kerala
commented

Looking forward to get solved!

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work
quietone’s picture

quietone commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt1.11 KB
new 3253893-13.patch27.34 KB

Remove use of deprecated markAsDefault, deprecated in commerce:8.x-2.16 and is removed from commerce:3.x.

Status: Needs review » Needs work

The last submitted patch, 13: 3253893-13.patch, failed testing. View results

quietone’s picture

quietone commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt3.04 KB
new 3253893-15.patch9.19 KB

Ignore that patch.

This one does:

  • Remove use of deprecated markAsDefault, deprecated in commerce:8.x-2.16 and is removed from commerce:3.x.
  • Fix \Drupal\Tests\commerce_migrate_commerce\Unit\Plugin\migrate\process\commerce1\CommerceAttributeHandlerSettingTest::providerTestException what was just wrong.
quietone’s picture

quietone commented
StatusFileSize
new 3253893-16.patch4.18 KB

Found out in testing that markAsDefault() was not the cause of the problem in the tests. The tests needed to install the schema for path_alias.

quietone’s picture

quietone commented
Version: 3.1.x-dev » 3.2.x-dev
quietone’s picture

quietone commented
StatusFileSize
new interdiff-16-18.txt679 bytes
new 3253893-18.patch5.02 KB

forgot to fix the commerce1 test.

quietone’s picture

quietone commented
Issue summary: View changes

  • quietone committed 43c1c62 on 3.2.x 
    Issue #3253893 by DamienMcKenna, quietone: Update codebase to be fully...
quietone’s picture

quietone commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.