[meeting] Migrate Meeting 2021-12-09 1400Z

• Custom migrations based on d7_file to create File and Media entities.
• Migrate Media Handler (for files referenced in and elements)
• Migrate File Entities to Media Entities (use case?)
• Media Migration (migrating from D7 Media)

• Migrate File Entities to Media Entities (use case?). - This module allows you to migrate Drupal 8.0 file entities to Drupal 8.5 media entities using the migrate module

it's a very limited use case.

Media Reference: Using the Record Media Ref Plugin

This plugin fills in the field_original_ref data with a hashed file path. This allows later entity migrations to lookup media data by file path.

 process:
   'field_original_ref':
   -
     plugin: migration_lookup
     source: field_old_image
     migration: example_file
     no_stub: true
   -
     plugin: record_media_ref

It's not obvious to me where to process this new field. In my node bundle migrations, I'm just initially migrating the file field with

field_file_attachment:
    -
      plugin: sub_process
      source: field_file_attachment
      process:
        target_id: fid
        display: display
        description: description

so I don't (yet) have a separate media migration, I'm not really migrating media entities, until now I was first migrating the files, then attempting to migrate those into new media entities. Is this the wrong approach?

field  field_document_media:    
    -    
      plugin: migration_lookup    
      source: field_file_attachemnt    
      migration: upgrade_d7_file    
      no_stub: true    
    -    
      plugin: update_file_to_document

      plugin: sub_process
-      source: field_file_attachment
-      process:
-        target_id: fid
-        display: display
-        description: description

field_document_media:
  plugin: subprocess
  source: field_file_attachment
  process:
    target_id:
      - 
        plugin: migration_lookup    
        source: field_file_attachemnt    
        migration: upgrade_d7_file    
        no_stub: true  
      -
        plugin: update_file_to_document<

field_document_media:
    -
      plugin: sub_process
      source: field_file_attachemnt
      process:
        target_id:
          -
            plugin: migration_lookup
            source: fid                                                                                                                                                       
            migration: upgrade_d7_file
            no_stub: true
          -
            plugin: update_file_to_document

?+ * - no_args: (optional) Whether to pass no arguments to the callback. To be
+ *   used in cases where a function does not accept arguments, such as time().
+ *
  *
  * Examples:
  *

• The feature request is not needed for any of the core migrations.
• It does not add much complexity.
• Is it useful enough to justify adding it to core?
• Is there any other way to handle the suggested use cases?

<br />
<b>Fatal error</b>:  Uncaught ArgumentCountError: time() expects exactly 0 arguments, 1 given in [...][...]:4
Stack trace:
#0 [...][...](4): time('')
#1 {main}  thrown in <b>[...][...]</b> on line <b>4</b><br />

php > function foo() { return time(); }
php > echo foo();
1639060902
php > echo foo('');
1639060906

That is PHP 7.4.

field_timestamp:
  plugin: service
  service: datetime.time
  method: getCurrentTime # or getRequestTime

process:
  time:
    plugin: callback
    callable: time
    unpack_source: true
    source: {  }

Should work just fine with the existing code…

If it didn’t work, (and it does)

In case there are any doubters, my test confirmed it works

Was that your idea

No

'pi' => [
  'pi',
  [],
  pi(),
],