| mstrelan |
Need ideas how to fix #2999813: Link display formatter breaks internal links with brackets in a query string |
| andypost |
@mstrelan brain dump is it should be opt-in for BC, there should be related issues about rendering links inside of a link even when browsers don't support it (edited) |
| mstrelan |
not sure i follow what you mean about rendering links inside links and browser support. the problem is that numeric keys (eg. tid[100] = 100) get reindexed (tid[0] = 100). |
| andypost |
My fault, then it related to js weights which needs love for many years and just needs to be rewritten (maybe in context of jQuery removal) (edited) |
| mstrelan |
also not js :smile:the unit test should demonstrate the problem. NestedArray:mergeDeep(). Problem is some keys are strings and some are integers. So something like an array of classes (that are numerically indexed) it doesn't matter if the keys are preserved. But with the query parameters for tids in a view the tid happens to be an int and can't be reindexed. |
| andypost |
Then it depends on database used, as not a long ago some databases started to return int instead of string for ints |
| andypost |
Curious about effect of PHP 8+ "natural sorting" feature |
| mstrelan |
there is a comment in NestedArray::mergeDeepArray:
// Renumber integer keys as array_merge_recursive() does unless
// $preserve_integer_keys is set to TRUE. Note that PHP automatically
// converts array keys that are integer strings (e.g., '1') to integers.
|
| dww |
Meta: It'd probably be nice to add subthreads for this topic for each request / issue. If I come in here and ask for what I need help with, it's gonna potentially ping the wrong people, if a few of us were trying to get help simultaneously it'd get messy, etc.Although it'd be weird for me to add a new subthread now since the room moved on and it's no longer meeting time. But maybe we allow a trickle of 4️⃣ .X threads into the room for the 24 hours that the meeting is "open"? |
| dww |
Although I guess :point_up: makes life harder for trying to save the meeting transcript to the issue. :cry: |
| dww |
Anyway, in the absence of subthreads, I could use a hand with getting the new UI help text right for #3150294: New translations for moderated nodes are not created in the initial workflow state -- UX team keeps not having time to re-review that (no fault, they've already spent good time on it). If anyone has ideas, refinements, improvements, etc, please comment there. Thanks! |
| Griffyn Heels |
Good thinking, I'll do that moving forward. |
| dww |
If we do subthreads, maybe we should plan to let this be the last topic of the meeting so it's easiest for folks to keep suggesting other subthreads until the end of the hour? |
| Griffyn Heels |
I'm very happy to leave it as is, but seems like a good opportunity to shake things up. |
| jibran |
Do you have anything in mind? |
| darvanen |
Host the daily triage in a different random slack channel every day :stuck_out_tongue: |
| Griffyn Heels |
It would probably get a lot of engagement, and then me booted out of a lot of channels. |
| darvanen |
pros / cons (edit: completely facetious comment) (edited) |
| Griffyn Heels |
I think the current approach works, more threads leads to less engagement I think. Happy to add more if something comes up consistently thought. |
| jibran |
Maybe just share the #bugsmash thread in appropriate channel if a bug belong there e.g. #config #layouts etc. |
| Griffyn Heels |
Thats a good idea, if a bug is related I'm happy to cross-post. |
| jibran |
#views, #migration, #contenta for jsonapi, #frontend, #composer |
| larowlan |
I still think it would be good to explore quietone and dww's idea about weekly major targets |
| darvanen |
As in - we work together to fully resolve a major instead of triaging and then allowing it to disappear into the fog again? I'd be for that. |
| larowlan |
yeah let me find the thread |
| larowlan |
https://drupal.slack.com/archives/C014QES6HSQ/p1637641770406500 |
| Griffyn Heels |
I'll spin that off into its own thread. Thanks Lee. |
| Kristen Pol (she/her) |
Nice idea of cross-posting issues... I'll try to remember that |
| dww |
Re: x-posting: In addition to the list of obvious channels above, specific shoutouts to #accessibility and #ux for mutual support -- they really appreciate our help and we really need them for many issues to get through core gates. (edited) |
| dww |
Also, hah, but I guess https://drupal.slack.com/archives/C014QES6HSQ/p1642550633066700?thread_t... would have been more appropriate to post in this thread (now that I got this far into the meeting). |
| Griffyn Heels |
Are people happy with the approach outlined here? |
| Griffyn Heels |
As quietone said, we can always trial and see how it goes after a few meetings. |
| darvanen |
Yes |
| quietone |
Just want to be sure. Does that mean this, "A random critical, a random major and 2 others to create a list of 4 to focus on for the fortnight." |
| quietone |
I recall dww was concerned about the work to generate the random issues. For the trial, I'll do that work. |
| Griffyn Heels |
I think that concern is justified, if you're happy to take that on for this first fortnight and then we can assess? |
| quietone |
Yes, after the little one is in bed and it is cooler I'll attend to that. |
| darvanen |
Just want to be sure. Does that mean this, "A random critical, a random major and 2 others to create a list of 4 to focus on for the fortnight."
That is what I was answer yes to, personally.Yes, valid concern.I'd also like to know what we plan to do with issues that don't get resolved within the fortnight. |
| quietone |
Good question. Probably a case by case basis. |
| jibran |
Should we reuse :dart: emoji? |
| larowlan |
for the unresolved ones, how about we have a vote 'keep going or drop it' in the next meeting |
| larowlan |
don't want to get to a point where all 4 slots are blocked for weeks on end |
| lendude |
Would it help if I added a button to generate these links (or somebody did an MR)? We have the issue priority in the API data we grab so should be doable |
| dww |
Re:I recall dww was concerned about the work to generate the random issues.
Not exactly. I am also concerned about that and not getting into a situation where there's too much overhead for any of our processes that is all falling to one person (@quietone).My primary concern was about the work to manage all the voting and other effort required by my original elaborate proposal to manually select targets. |
The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.
Comments
Comment #2
griffynh commentedComment #3
griffynh commentedComment #4
griffynh commentedComment #5
griffynh commentedComment #14
quietone commentedComment #15
quietone commentedComment #16
quietone commentedNo changes requested at following meeting.