Problem/Motivation

Schema for match_limit and webforms parameters are missing in entity reference autocomplete widget.

Steps to reproduce

  1. Setup this widget for your webform field in your entity form display
  2. Install config inspector
  3. You can see missing schema errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#9 3252811-9.patch7.97 KBjrockowitz
#6 3252811-6.patch1.11 KBjrockowitz
#3 3252811-3.patch776 bytesjrockowitz
#2 webform-3252811-2.patch709 byteslamp5

Comments

lamp5 created an issue. See original summary.

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
commented
Status: Active » Needs review
StatusFileSize
new webform-3252811-2.patch709 bytes
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3252811-3.patch776 bytes

The webforms property can contain multiple strings.

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
commented

Hmm, intresting, I can see error when value is empty.

jrockowitz’s picture

jrockowitz commented

I think we need to change the default value for webforms property from NULL to an empty array [].

jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3252811-6.patch1.11 KB

I think we need to the 'ignore' type.

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
commented

"Ignore" type it is not correct in my opinion, it is good for password form element type for example. Change default property for empty array sounds better.

jrockowitz’s picture

jrockowitz commented

Setting it to an empty array breaks the existing code.

@see \Drupal\webform\Plugin\Field\FieldWidget\WebformEntityReferenceWidgetTrait::settingsForm

jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3252811-9.patch7.97 KB

Moving and refactory the default settings, settings form, and settings summary out of the trait is the most reliable approach.

jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

  • jrockowitz committed b5054cc on 6.x 
    Issue #3252811 by jrockowitz, lamp5: Schema for match_limit and webforms...

  • jrockowitz committed b5054cc on 6.1.x 
    Issue #3252811 by jrockowitz, lamp5: Schema for match_limit and webforms...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.