@see Consider including a compiled version of the progress tracker's css #27

Steps to review

  • Install the progress tracker library (drush wfld).
  • Confirm that css is /docs is being used.
  • Apply patch
  • Clear cache
  • Confirm that css is /docs is still being used.
  • Remove the progress tracker library (drush wflr)
  • Confirm that CSS css is now using /src.
  • Install the update progress tracker library (drush wfld).
  • Confirm that CSS css is still using /src.

Issue fork webform-3252116

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jrockowitz created an issue. See original summary.

jrockowitz’s picture

jrockowitz commented
Title: Use ompiled progress tracker's css. » Use compiled progress tracker's css.
jrockowitz’s picture

jrockowitz commented
Status: Active » Postponed

Because this change requires Progress Tracker 2.0.7, which means anyone that upgrades Webform WITHOUT updating their external libraries will have a broken progress tracker.

I think this change would either have to be merged into Webform 6.2.x or 7.x.

jrockowitz’s picture

jrockowitz commented
Title: Use compiled progress tracker's css. » [Webform 6.2.x || 7.x] Use compiled progress tracker's css.
jrockowitz’s picture

jrockowitz commented
Status: Postponed » Needs work

I think the solution might be to add a backward compatibility layer to support older versions of the progress library.

jrockowitz’s picture

jrockowitz commented
Issue summary: View changes
Status: Needs work » Needs review

jrockowitz opened merge request !114

jrockowitz’s picture

jrockowitz commented
Title: [Webform 6.2.x || 7.x] Use compiled progress tracker's css. » Use compiled progress tracker's css.

Since this PR includes backward compatibility it can be committed at any time.

  • jrockowitz committed 8480d41 on 6.1.x 
    Issue #3252116 by jrockowitz: Use compiled progress tracker's css
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

  • jrockowitz committed 8480d41 on 6.x 
    Issue #3252116 by jrockowitz: Use compiled progress tracker's css

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.