Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

reloxo95 created an issue. See original summary.

murilohp’s picture

Assigned: Unassigned » murilohp
Issue summary: View changes
murilohp’s picture

Version: 8.x-1.1 » 8.x-1.x-dev
Assigned: murilohp » Unassigned
Issue summary: View changes
Status: Active » Needs review

I used the "upgrade_status" lib to check the module, and no issues for D9 upgrade were found:

drush upgrade_status:analyze lightgallery
[notice] Processing /app/modules/contrib/lightgallery.

================================================================================
Light Gallery, --
Scanned on Mon, 11/22/2021 - 12:34

No known issues found.

For this scenario, a maintainer needs to change the module to page. So I'm moving this issue to needs review, if you have any issues with D9 please let me know!

Thanks!

Jelle_S made their first commit to this issue’s fork.

jelle_s’s picture

I created a fork to start on D9 compatibility, but everything is already ok (I thought I'd still had to add the core_version_requirement: ^8 || ^9 to the .info.yml file, but even that is fixed in the latest dev it seems).

So it's just a matter of tagging & releasing a new version. Especially since Lightgallery 8.x-1.1 is now marked as unsupported.

nessunluogo’s picture

Everything is working fine except there's no version supported for Drupal 8/9 anymore and I get Updates notifications from my sites.

nessunluogo’s picture

Priority: Normal » Critical
rgnyldz’s picture

I'm too using this module without any problems so far exept the "not supported" message in my updates page. How can we help to make a stabe version for this module. Is the maintainer reachable?

robin.ingelbrecht’s picture

I'm looking for co-maintainers as I'm not involved in Drupal anymore...

murilohp’s picture

Hey @robin.ingelbrecht, if you want to, I can help you with that, I can release a new version for drupal 9 and review some issues of this module.

robin.ingelbrecht’s picture

@murilohp that would be a huge help! I'll give you some extra permisisons ;)

murilohp’s picture

Status: Needs review » Fixed

Thanks for giving me access @robin.ingelbrecht! I just created a new release 1.2, this new release has the support for D9, see: https://www.drupal.org/project/lightgallery/releases/8.x-1.2 for more details.

At this moment the release is not appearing on the module page, I think you have to change my permission @robin.ingelbrecht, there's a permission called "update project", anyone with this permission can promote the releases to the front page.

I'll move this to fixed.

robin.ingelbrecht’s picture

@murilohp done :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.