Problem/Motivation

The following deprecation warning is triggered running tests:

$modules property must be declared protected. See https://www.drupal.org/node/2909426

Steps to reproduce

Proposed resolution

Change it to protected as per the change record

Remaining tasks

Issue fork search_api-3249792

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kim.pepper created an issue. See original summary.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented

kim.pepper opened merge request !21

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Title: Deprecation warning: $modules property must be declared protected in BackendTestBase » Deprecation warning: $modules property must be declared protected

Renaming as this changes all public to protected in test classes.

kim.pepper’s picture

kim.pepper
Primary language English
Location 🏄‍♂️🇦🇺Sydney, Australia
commented
Status: Active » Needs review
fubarhouse’s picture

fubarhouse commented

Had a quick look, looks great and as advertised.

borisson_ made their first commit to this issue’s fork.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Fixed

Thanks @kim.pepper!

  • borisson_ committed 20698e6 on 8.x-1.x authored by kim.pepper 
    Issue #3249792 by kim.pepper: Deprecation warning: $modules property...

  • drunken monkey committed f68480c on 8.x-1.x 
    Follow-up to #3249792 by drunken monkey: Updated CHANGELOG.txt.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.