Closed (fixed)
Project:
Project Browser
Version:
1.0.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
15 Nov 2021 at 20:37 UTC
Updated:
13 Oct 2022 at 13:59 UTC
Jump to comment: Most recent
Comments
Comment #2
tedbowComment #5
omkar.podey commentedNote - Should not be merged until 3245770 gets merged.
Comment #6
omkar.podey commentedComment #7
omkar.podey commentedComment #8
omkar.podey commentedComment #9
phenaproximaI think this is coming along, but it's a little unfocused and feels like some parts of it were copied-and-pasted from another validator. I've left a few comments in an effort to clarify what we're trying to do, and remove code that is not necessary to the task at hand.
Comment #10
omkar.podey commentedComment #11
tedbowComment #12
tedbowLooking pretty good!
Comment #13
tedbowNeeds work for merge request comments
Comment #14
omkar.podey commentedComment #15
tedbowComment #16
tedbowLooks good. @omkar.podey thanks for all the work!
Comment #17
narendrarComment #18
tim.plunkettThis needs work after #3306722: Update Installer service to work without requiring to specify the package version landed
Comment #19
omkar.podey commentedComment #20
omkar.podey commentedComment #21
omkar.podey commentedFor this test to pass first #3310000: RequireEventTrait should default unspecified version constraints to * this needs to be merged.
Comment #22
omkar.podey commentedComment #23
phenaproximaBlocked by #3310000: RequireEventTrait should default unspecified version constraints to *.
Comment #24
tim.plunkettThat landed!
Comment #25
omkar.podey commentedComment #26
omkar.podey commentedComment #27
traviscarden commentedComment #28
omkar.podey commentedBlocked on Upstream Changes, failures are unreleated to the issue.
Comment #29
omkar.podey commentedComment #30
phenaproximaThis looks straightforward to me.
Comment #32
tim.plunkettMerged, thanks!