Ran a simple test to check for all the deprecated functions and I noticed, most of the tests are using methods that have been marked as deprecated. Adding a patch to replace them.

CommentFileSizeAuthor
#14 interdiff-10-14.txt3.83 KBgaurav.kapoor
#14 3249485-14.patch8.51 KBgaurav.kapoor
#10 3249485-10.patch8.04 KBgaurav.kapoor
#7 3249485-7-test-only.patch7.03 KBgaurav.kapoor
#2 3249485-2.patch6.76 KBgaurav.kapoor

Comments

gaurav.kapoor created an issue. See original summary.

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Active » Needs review
StatusFileSize
new 3249485-2.patch6.76 KB

Status: Needs review » Needs work

The last submitted patch, 2: 3249485-2.patch, failed testing. View results

gaurav.kapoor’s picture

gaurav.kapoor commented
Assigned: Unassigned » gaurav.kapoor

Working on why tests are failing.

rsvelko’s picture

rsvelko commented

Watching this one and will commit/push as needed.

rsvelko’s picture

rsvelko commented

btw, is this ready to commit and push? Maybe the tests are failing due to some other reason?

gaurav.kapoor’s picture

gaurav.kapoor commented
StatusFileSize
new 3249485-7-test-only.patch7.03 KB

Adding a test only patch to check why test cases are failing.

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 7: 3249485-7-test-only.patch, failed testing. View results

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs work » Needs review
StatusFileSize
new 3249485-10.patch8.04 KB

Another set of fixes added...

Status: Needs review » Needs work

The last submitted patch, 10: 3249485-10.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

rsvelko’s picture

rsvelko commented

https://www.drupal.org/pift-ci-job/2238748 has clues as to why tests fail.
No time to debug this myself, though. Only to apply patches.

gaurav.kapoor’s picture

gaurav.kapoor commented

Still getting following errors, when running tests in local. Working on these.

PHPUnit 9.5.11 by Sebastian Bergmann and contributors.

Runtime:       PHP 7.4.27
Configuration: /app/phpunit.xml
Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

Testing /app/web/modules/contrib/login_destination
....EEEEEEE...E                                                   15 / 15 (100%)

Time: 01:58.396, Memory: 10.00 MB

There were 8 errors:

1) Drupal\Tests\login_destination\Functional\RedirectTest::testRedirectAfterRegistering
TypeError: Argument 1 passed to Drupal\Tests\BrowserTestBase::submitForm() must be of the type array, string given, called in /app/web/modules/contrib/login_destination/tests/src/Functional/RedirectTest.php on line 109

/app/web/core/tests/Drupal/Tests/UiHelperTrait.php:67
/app/web/modules/contrib/login_destination/tests/src/Functional/RedirectTest.php:109
/app/web/modules/contrib/login_destination/tests/src/Functional/RedirectTest.php:163
/app/vendor/phpunit/phpunit/src/Framework/TestResult.php:726

2) Drupal\Tests\login_destination\Functional\RedirectTest::testNoRedirectAfterRegistering
TypeError: Argument 1 passed to Drupal\Tests\BrowserTestBase::submitForm() must be of the type array, string given, called in /app/web/modules/contrib/login_destination/tests/src/Functional/RedirectTest.php on line 109

/app/web/core/tests/Drupal/Tests/UiHelperTrait.php:67
/app/web/modules/contrib/login_destination/tests/src/Functional/RedirectTest.php:109
/app/web/modules/contrib/login_destination/tests/src/Functional/RedirectTest.php:190
/app/vendor/phpunit/phpunit/src/Framework/TestResult.php:726

3) Drupal\Tests\login_destination\Functional\RedirectTest::testRedirectAfterOneTimeLoginAndSettingPassword
TypeError: Argument 1 passed to Drupal\Tests\BrowserTestBase::submitForm() must be of the type array, string given, called in /app/web/modules/contrib/login_destination/tests/src/Functional/RedirectTest.php on line 206

/app/web/core/tests/Drupal/Tests/UiHelperTrait.php:67
/app/web/modules/contrib/login_destination/tests/src/Functional/RedirectTest.php:206
/app/vendor/phpunit/phpunit/src/Framework/TestResult.php:726

4) Drupal\Tests\login_destination\Functional\RedirectTest::testNoRedirectAfterOneTimeLoginAndSettingPassword
TypeError: Argument 1 passed to Drupal\Tests\BrowserTestBase::submitForm() must be of the type array, string given, called in /app/web/modules/contrib/login_destination/tests/src/Functional/RedirectTest.php on line 244

/app/web/core/tests/Drupal/Tests/UiHelperTrait.php:67
/app/web/modules/contrib/login_destination/tests/src/Functional/RedirectTest.php:244
/app/vendor/phpunit/phpunit/src/Framework/TestResult.php:726

5) Drupal\Tests\login_destination\Functional\RedirectTest::testRedirectImmediatelyAfterOneTimeLogin
TypeError: Argument 1 passed to Drupal\Tests\BrowserTestBase::submitForm() must be of the type array, string given, called in /app/web/modules/contrib/login_destination/tests/src/Functional/RedirectTest.php on line 277

/app/web/core/tests/Drupal/Tests/UiHelperTrait.php:67
/app/web/modules/contrib/login_destination/tests/src/Functional/RedirectTest.php:277
/app/vendor/phpunit/phpunit/src/Framework/TestResult.php:726

6) Drupal\Tests\login_destination\Functional\RedirectTest::testNoRedirectImmediatelyAfterOneTimeLogin
TypeError: Argument 1 passed to Drupal\Tests\BrowserTestBase::submitForm() must be of the type array, string given, called in /app/web/modules/contrib/login_destination/tests/src/Functional/RedirectTest.php on line 306

/app/web/core/tests/Drupal/Tests/UiHelperTrait.php:67
/app/web/modules/contrib/login_destination/tests/src/Functional/RedirectTest.php:306
/app/vendor/phpunit/phpunit/src/Framework/TestResult.php:726

7) Drupal\Tests\login_destination\Functional\RedirectTest::testNoRedirectAfterUpdatingAccountWithoutLoginLink
TypeError: Argument 1 passed to Drupal\Tests\BrowserTestBase::submitForm() must be of the type array, string given, called in /app/web/modules/contrib/login_destination/tests/src/Functional/RedirectTest.php on line 329

/app/web/core/tests/Drupal/Tests/UiHelperTrait.php:67
/app/web/modules/contrib/login_destination/tests/src/Functional/RedirectTest.php:329
/app/vendor/phpunit/phpunit/src/Framework/TestResult.php:726

8) Drupal\Tests\login_destination\Functional\UrlParameterTest::testNoParameterOnUnroutedLink
TypeError: Argument 2 passed to PHPUnit\Framework\Assert::assertNotContains() must be iterable, string given, called in /app/web/modules/contrib/login_destination/tests/src/Functional/UrlParameterTest.php on line 35

/app/web/modules/contrib/login_destination/tests/src/Functional/UrlParameterTest.php:35
/app/vendor/phpunit/phpunit/src/Framework/TestResult.php:726

ERRORS!
Tests: 15, Assertions: 108, Errors: 8.
gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs work » Needs review
StatusFileSize
new 3249485-14.patch8.51 KB
new interdiff-10-14.txt3.83 KB

Fixed all the errors and warnings :fingers-crossed.

Status: Needs review » Needs work

The last submitted patch, 14: 3249485-14.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs work » Needs review

The tests are passing when running with D9 environment, PHP 7.4 and MySQL ( > 5.7) as expected. Setting it to needs review.

rsvelko’s picture

rsvelko commented
Status: Needs review » Fixed

I've taken the good bits of your patch and tested against latest 8.x-2.x dev branch codebase in drupal 9.x with PHP 8.1.
After some more fixing - all is good now. Tests passed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.