Problem/Motivation

The negate logic is handled with core's ConditionManager class and therefore this module shouldn't handle the negate logic within the condition plugin itself.

Proposed resolution

Remove negate logic from the condition plugin.

Add unit test to check the condition on a node that doesn't have the target field in its definition.

Issue fork node_boolean-3247629

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

JoshHytr created an issue. See original summary.

JoshHytr opened merge request !1

JoshHytr closed merge request !1

JoshHytr opened merge request !2

joshhytr’s picture

joshhytr commented
Status: Active » Needs review

I've opened a merge request with the following changes:

  • Remove negate logic from condition plugin
  • Remove negate unit tests
  • Add unit test to check the condition on a node that doesn't have the target field in its definition evaluates to FALSE

  • andy_w committed b8c5915 on 8.x-1.x authored by JoshHytr 
    Issue #3247629: Negate logic should not be handled within condition...
andy_w’s picture

andy_w commented
Status: Needs review » Fixed

Thanks for this, great work! I have no idea how I missed this.

Merged into release 1.9

andy_w’s picture

andy_w commented
Status: Fixed » Closed (fixed)