Some places with incorrect escaping or plain text conversion. The first one has been causing random test fails.

1) Double conversion to plain text. MailEntity::getBodyWithFormat() calls MailFormatHelper::htmlToText() and then due to #3174760: Mails resembling HTML are corrupted so does PhpMail::format(). Core may never be fixed, but we can workaround it by removing our conversion.

2) Unwanted HTML-escaping in subject, giving incorrect output if it contains an HTML entity. This occurs because we pass markup for the subject, but not implementing MarkupInterface. This isn't a bug with the core mail system due to #2575791: Mail subject should not be run through strip_tags(), but it is visible when using Symfony Mailer.

CommentFileSizeAuthor
#4 simplenews.escaping-conversion.3247321-interdiff-2-4.txt801 bytesadamps
#4 simplenews.escaping-conversion.3247321-4.patch3.98 KBadamps
#2 simplenews.escaping-conversion.3247321-2.patch3.13 KBadamps

Comments

AdamPS created an issue. See original summary.

adamps’s picture

adamps commented
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new simplenews.escaping-conversion.3247321-2.patch3.13 KB

Status: Needs review » Needs work

The last submitted patch, 2: simplenews.escaping-conversion.3247321-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

adamps’s picture

adamps commented
Status: Needs work » Needs review
StatusFileSize
new simplenews.escaping-conversion.3247321-4.patch3.98 KB
new simplenews.escaping-conversion.3247321-interdiff-2-4.txt801 bytes
adamps’s picture

adamps commented
Issue tags: +Plan to commit
adamps’s picture

adamps commented
Status: Needs review » Fixed
Issue tags: -Plan to commit

  • AdamPS committed e572bf0 on 3.x 
    Issue #3247321 by AdamPS: Incorrect HTML escaping / conversion to plain

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.