Problem/Motivation

When running npm run build, the build files which are getting generated are not mentioned in the .gitignore file and due to which those files are shown in the untracked files.

Steps to reproduce

Run npm run build and git status (This issue is only valid when using cloned version)

Proposed resolution

We should modify .gitignore so that developers are able to do a clean commit easily.

Remaining tasks

  • ✅ File an issue about this project
  • ✅ Addition/Change/Update/Fix to this project
  • ☐ Testing to ensure no regression
  • ☐ Automated unit/functional testing coverage
  • ☐ Developer Documentation support on feature change/addition
  • ☐ User Guide Documentation support on feature change/addition
  • ☐ Code review from 1 Drupal core team member
  • ☐ Full testing and approval
  • ☐ Credit contributors
  • ☐ Review with the product owner
  • ☐ Release
CommentFileSizeAuthor
#2 3245954-2.patch227 bytesgaurav.kapoor

Comments

gaurav.kapoor created an issue. See original summary.

gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Active » Needs review
StatusFileSize
new 3245954-2.patch227 bytes

Adding a patch for this minor fix.

gaurav.kapoor’s picture

gaurav.kapoor commented
Issue summary: View changes
gaurav.kapoor’s picture

gaurav.kapoor commented
Status: Needs review » Closed (works as designed)

As discussed, in the Project Browser meeting, it may not be a good idea to add the files generated by the build process to .gitignore. If we do that, all those who install the module will have to run the build process. For now, developers can just ignore them and push them only if there are changes in the Svelte app.

Marking this as closed for now, but feel free to reopen if you think this can be handled in a better way.