First, thanks a lot for the improvements in this module, the upgrade experience is a lot smoother thanks to it!

Problem/Motivation

When both modules and themes are analyzed, and the related info files do not yet declare compatibility with Drupal 9, the message shown is the following.

Add core_version_requirement: ^8 || ^9 to designate that the module is compatible with Drupal 9. See https://drupal.org/node/3070687.

This is as expected for modules, but a bit strange for themes.

Steps to reproduce

Scan a theme without drupal 9 support declared.
Rhe message is presented on the details.

Proposed resolution

It may be worth to just generalize the term, instead of module, use something more generic that fits both modules and themes, e.g. extension.

Remaining tasks

Provide code changes.
See if tests pass correctly.
Code review.

User interface changes

String change making the output a bit more clear.

API changes

N.A.

Data model changes

N.A.

Comments

marvil07 created an issue. See original summary.

marvil07’s picture

Assigned: marvil07 » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new2.51 KB

Here the suggested change.

marvil07’s picture

Title: Stop referencing theme extensions modules » Stop referencing theme extensions as modules

  • bcca5cc committed on 8.x-3.x
    Issue #3245870 by marvil07: Stop referencing theme extensions as modules
    
gábor hojtsy’s picture

Status: Needs review » Fixed

Good find! Thanks for the fix. We reference extensions elsewhere too, such as a few lines below about deprecated extensions. So this wording sounds good.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.