First, thanks a lot for the improvements in this module, the upgrade experience is a lot smoother thanks to it!
Problem/Motivation
When both modules and themes are analyzed, and the related info files do not yet declare compatibility with Drupal 9, the message shown is the following.
Add core_version_requirement: ^8 || ^9 to designate that the module is compatible with Drupal 9. See https://drupal.org/node/3070687.
This is as expected for modules, but a bit strange for themes.
Steps to reproduce
Scan a theme without drupal 9 support declared.
Rhe message is presented on the details.
Proposed resolution
It may be worth to just generalize the term, instead of module, use something more generic that fits both modules and themes, e.g. extension.
Remaining tasks
Provide code changes.
See if tests pass correctly.
Code review.
User interface changes
String change making the output a bit more clear.
API changes
N.A.
Data model changes
N.A.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 3245870-2-generalize-wording-for-extensions.patch | 2.51 KB | marvil07 |
Comments
Comment #2
marvil07 commentedHere the suggested change.
Comment #3
marvil07 commentedComment #5
gábor hojtsyGood find! Thanks for the fix. We reference extensions elsewhere too, such as a few lines below about deprecated extensions. So this wording sounds good.