Would like to maintain this project, as we use this module in one of the projects. We are unable to upgrade Drupal 8 to 9 because of this dependency we are maintaining this as a manual process. We have converted this module to Drupal 9 compatible.
We do have a Vetted Role, please provide maintainership of this project.
Contacted to Karthik Kumar D K (heykarthikwithu) via mail on 22nd October 2021.
Hello Karthik,
we would like to maintain this project, as we use this module in one of the
projects.
please add me as a maintainer to this project to maintain the Drupal 9
release.
Thanks,
Rajeshreeputra
Comments
Comment #2
rajeshreeputraComment #3
rajeshreeputraComment #4
heykarthikwithuHi @Rajeshreeputra, Would be happy to provide you maintainership, please can you pick a few bugs and get patches to those - https://www.drupal.org/project/issues/like_dislike?categories=All
Comment #5
rajeshreeputraBelow are the PHPCS issue in 2.0.x branch:
patch added here fixes those, please review.
FILE: C:\xampp7\htdocs\drupal-9.2.1\modules\contrib\like_dislike\css\like_dislike.css
-------------------------------------------------------------------------------------
FOUND 23 ERRORS AFFECTING 23 LINES
-------------------------------------------------------------------------------------
2 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
4 | ERROR | [x] Multiple selectors should each be on a single line
5 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
6 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
9 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
10 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
12 | ERROR | [x] Multiple selectors should each be on a single line
13 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
16 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
18 | ERROR | [x] Multiple selectors should each be on a single line
19 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
21 | ERROR | [x] Multiple selectors should each be on a single line
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
23 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
26 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
31 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
32 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
33 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 23 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------
FILE: C:\xampp7\htdocs\drupal-9.2.1\modules\contrib\like_dislike\like_dislike.module
------------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 4 LINES
------------------------------------------------------------------------------------
5 | ERROR | [x] Doc comment short description must start with a capital letter
67 | ERROR | [x] Short array syntax must be used to define arrays
68 | ERROR | [x] Short array syntax must be used to define arrays
69 | ERROR | [x] Short array syntax must be used to define arrays
------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------
FILE: C:\xampp7\htdocs\drupal-9.2.1\modules\contrib\like_dislike\README.txt
---------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------
37 | WARNING | [ ] Line exceeds 80 characters; contains 81 characters
37 | ERROR | [x] Expected 1 newline at end of file; 0 found
---------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------
FILE: C:\xampp7\htdocs\drupal-9.2.1\modules\contrib\like_dislike\src\Controller\LikeDislikeController.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 28 ERRORS AND 1 WARNING AFFECTING 23 LINES
-------------------------------------------------------------------------------------------------------------------------------
21 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
52 | ERROR | [ ] Parameter $renderer is not described in comment
61 | ERROR | [ ] Missing parameter name
91 | ERROR | [x] Data types in @return tags need to be fully namespaced
98 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
115 | ERROR | [ ] Unnecessarily gendered language in a comment
128 | ERROR | [ ] key_exists() is a function name alias, use array_key_exists() instead
135 | ERROR | [x] Expected one space after the comma, 0 found
138 | ERROR | [x] Concat operator must be surrounded by a single space
150 | ERROR | [x] Concat operator must be surrounded by a single space
161 | ERROR | [ ] Description for the @return value is missing
163 | ERROR | [ ] Protected method name "LikeDislikeController::like_dislike_login_register" is not in lowerCamel format
164 | ERROR | [x] Short array syntax must be used to define arrays
165 | ERROR | [x] Short array syntax must be used to define arrays
166 | ERROR | [x] Short array syntax must be used to define arrays
178 | ERROR | [x] Short array syntax must be used to define arrays
179 | ERROR | [x] Short array syntax must be used to define arrays
180 | ERROR | [x] Concat operator must be surrounded by a single space
180 | ERROR | [x] Concat operator must be surrounded by a single space
189 | ERROR | [ ] Missing parameter comment
189 | ERROR | [x] Data types in @param tags need to be fully namespaced
190 | ERROR | [ ] Missing parameter comment
190 | ERROR | [ ] Missing parameter type
191 | ERROR | [x] Separate the @param and @return sections by a blank line.
191 | ERROR | [ ] Description for the @return value is missing
191 | ERROR | [x] Data types in @return tags need to be fully namespaced
193 | ERROR | [ ] Protected method name "LikeDislikeController::like_dislike_status" is not in lowerCamel format
193 | ERROR | [x] Expected one space after the comma, 0 found
195 | ERROR | [x] Concat operator must be surrounded by a single space
-------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 17 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------------
FILE: C:\xampp7\htdocs\drupal-9.2.1\modules\contrib\like_dislike\src\Plugin\Field\FieldFormatter\LikeDislikeFormatter.php
------------------------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AND 2 WARNINGS AFFECTING 5 LINES
------------------------------------------------------------------------------------------------------------------------------
91 | ERROR | [x] Short array syntax must be used to define arrays
100 | ERROR | [x] Short array syntax must be used to define arrays
110 | WARNING | [x] There must be no blank line following an inline comment
110 | WARNING | [ ] There must be no blank line following an inline comment
118 | ERROR | [x] Incorrect spacing between argument "$langcode" and equals sign; expected 1 but found 0
118 | ERROR | [x] Incorrect spacing between default value and equals sign for argument "$langcode"; expected 1 but found 0
147 | ERROR | [x] Whitespace found at end of line
------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------------
FILE: C:\xampp7\htdocs\drupal-9.2.1\modules\contrib\like_dislike\src\Plugin\Field\FieldType\LikeDislikeField.php
----------------------------------------------------------------------------------------------------------------
FOUND 5 ERRORS AFFECTING 5 LINES
----------------------------------------------------------------------------------------------------------------
26 | ERROR | [x] Short array syntax must be used to define arrays
27 | ERROR | [x] Short array syntax must be used to define arrays
28 | ERROR | [x] Short array syntax must be used to define arrays
33 | ERROR | [x] Short array syntax must be used to define arrays
38 | ERROR | [x] Short array syntax must be used to define arrays
----------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------------------
FILE: C:\xampp7\htdocs\drupal-9.2.1\modules\contrib\like_dislike\Tests\Controller\LikeDislikeControllerTest.php
---------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------
14 | ERROR | [x] Expected 1 blank line before function; 0 found
15 | ERROR | [x] Short array syntax must be used to define arrays
25 | WARNING | [ ] Possible useless method overriding detected
---------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------
Time: 2.39 secs; Memory: 10MB
Comment #6
rajeshreeputrahere is the patch for issue Does not count up with ajax. Works only after reload.
please apply like_dislike-3245270-5.patch first and then like_dislike-3195755.patch as this is generated after PHPCS issue fixes.
Comment #7
rajeshreeputrahere is the patch for issue - Only Like field with disabled Dislike item.
please apply like_dislike-3245270-5.patch first and then like_dislike-3034366.patch as this is generated after PHPCS issue fixes.
Comment #8
heykarthikwithuHi @Rajeshreeputra, added you to the maintainers list.