"core/drupal.checkbox" (misc/checkbox.js) has never loaded on user permission page

Fix line-endings in patch

needs some test to extend

Thanks for the issue and patch. Tagging for testing, updating the issue summary to use the template, and add screenshots.

Seems like it would be hard to add a manual test but I'll leave that to someone who writes tests to decide :)

Confirmed the behaviour manually, and added a functional JS test.

What should happen is that disabled pre-selected checkboxes appear for other roles when you select the "authenticated user" role for any permission, as that overrides all other roles. Without the patches the dummy checkboxes don't appear; instead the per-role checkboxes just disappear, which isn't as clear to the user as to what it means.

Hi posting my QA observation before the patch

Testing steps before patch :
1. Go to the admin site.
2. Go to admin/appearance >> Enable the Seven theme as default
3. Go to the people >> Permission tab
4. Now check the checkbox for the Authenticated user and observe for other checkbox permission
5. Now issue is after checking the Authenticated user other checkbox are getting disappear.

Testing Result after applying patch :
1. After applying the patch and after checking the AUTHENTICATED USER checkbox now other checkbox is visible and by default CONTENT EDITOR checkbox also getting checked and disabled.
2. Secondly there is no load response upon check and uncheck on network tab.

Thanks for testing @Satyajit1990, but you don't need to check any boxes.

The issue is that the file misc/checkbox.js isn't loaded when you are on this page, which you should be able to see in the Network tab. After the patch, you should be able to see the misc/checkbox.js file loaded on this page in the Network tab.

Tested the patch with the following steps.
- Fresh Drupal install with admin theme set as seven.
- Check the network tab on permission page, misc/checkbox.js won't be loaded
- Apply the patch, clear cache and check the net work tab again.
- misc/checkbox.js should be loaded.
Note: -You will need to disable Aggregate and clear cache to see file list.
Before Patch

After Patch

Updated the issue summary with test steps.

Looks like an unrelated failure so retesting.

Back to RTBC, test failures were unrelated.

Unrelated failure. Back to RTBC.

And again :(

Looks like test failures are unrelated.

Fixed the below issue
Drupal\Tests\quickedit\FunctionalJavascript\QuickEditFileTest
fail: [Other] Line 0 of sites/default/files/simpletest/phpunit-147.xml:
PHPUnit Test failed to complete; Error: PHPUnit 9.5.19 �[44m#StandWith�[0m�[43mUkraine�[0m

Warning: Your XML configuration validates against a deprecated schema.
Suggestion: Migrate your XML configuration using "--migrate-configuration"!

Attaching the updated patch

#22 is out of scope, phpunit.xml needs to remain compatible with both PHPUnit 8 and 9 for now.

Patch #7 appears to still work on 10.1.x and was marked RTBC before #22 so putting back and hiding patch #22

Cleaned up the issue summary, and removed explicit reference to the Seven theme, as this happens with Claro as well (tested before/after patch and confirmed).

Checking the network tab in the browser for presence of the misc/checkbox.js file is one thing to test for, but testing for the actual checkbox behavior being restored is also a valid, additional thing to check and confirm.

+++ b/core/modules/user/tests/src/FunctionalJavascript/UserPermissionsTest.php
@@ -0,0 +1,79 @@
+    $this->assertFalse($real_checkbox->isVisible());
+    $this->assertTrue($dummy_checkbox->isVisible());
+    $this->assertTrue($dummy_checkbox->isChecked());

I was going to ask that we also add another assertTrue for the real checkbox (i.e that it remains checked) but then read the code of user.permissions.js and saw that it doesn't do anything to the checked state, only the style properties.

Updating issue credits

Committed to 10.1.x and backported to 10.0.x and 9.5.x