Method "Symfony\Component\DependencyInjection\ContainerInterface::get()" will return "?object" as of its next major version. Doing the same in implementation "Drupal\Component\DependencyInjection\Container" will be required when upgrading.
Method "Symfony\Component\DependencyInjection\ContainerInterface::has()" will return "bool" as of its next major version. Doing the same in implementation "Drupal\Component\DependencyInjection\Container" will be required when upgrading.
Method "Symfony\Component\DependencyInjection\ContainerInterface::getParameter()" will return "array|bool|string|int|float|null" as of its next major version. Doing the same in implementation "Drupal\Component\DependencyInjection\Container" will be required when upgrading.
Method "Symfony\Component\DependencyInjection\ContainerInterface::hasParameter()" will return "bool" as of its next major version. Doing the same in implementation "Drupal\Component\DependencyInjection\Container" will be required when upgrading.
Method "Symfony\Component\DependencyInjection\ContainerInterface::initialized()" will return "bool" as of its next major version. Doing the same in implementation "Drupal\Component\DependencyInjection\Container" will be required when upgrading.
Add the return type hints.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | 3238485-3.patch | 4.44 KB | daffie |
Comments
Comment #2
daffie commentedPostponed on #3232095: [Symfony 6] Refactor the "update.root" service to return an object not a string.
Comment #3
daffie commentedThe patch from #3232095-7: [Symfony 6] Refactor the "update.root" service to return an object not a string.
Comment #4
longwaveThis needs to be committed to at least 10.0.x so we can upgrade to Symfony 5.4.
Comment #5
longwaveComment #7
catchCommitted 21d2543 and pushed to 10.0.x. Thanks!
Real test failures in 9.3 so looks like this is 10.x-only. We can revive it if we find something that needs backporting after all.
Comment #8
longwave9.3 is running into #3232095: [Symfony 6] Refactor the "update.root" service to return an object not a string which is 9.4 only; adding a 9.4 test to see what happens there.