Problem/Motivation

Users may not see how to add a link if they are using Layout Builder

Steps to reproduce

  • Install 6.0.0-beta2 version of Linkit
  • Enable Layout Builder to work for the Article or Basic Page content type
  • Create a page or article node and create a Basic Block to go on it with Layout Builder and add a link in the body field (such as a "mailto" email link)
  • Notice that the button to turn your email address into a "mailto" link is obscured and you have to know to scroll down in the short window to be able to see something to click to make it a "mailto" link as shown below in screenshot.

screenshot of linkit

Proposed resolution

One option is to make the window taller, so a user can see there's something there to click
Another option would be to have the window lap over top the surrounding part of the form like it does when a user would edit the body field of the page (not using Layout Builder)

What I think I should see is shown below:

screenshot of linkit

CommentFileSizeAuthor
#3 1-show-autocomplete-results.patch337 bytesricksta
Screen Shot 2021-09-16 at 4.46.16 PM.png44.28 KBricksta
Screen Shot 2021-09-16 at 4.50.40 PM.png35.71 KBricksta

Comments

ricksta created an issue. See original summary.

ricksta’s picture

ricksta commented
Issue summary: View changes
ricksta’s picture

ricksta commented
StatusFileSize
new 1-show-autocomplete-results.patch337 bytes
ricksta’s picture

ricksta commented
Status: Active » Needs review
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Needs review » Reviewed & tested by the community

Adding "position: relative" to the modal in order to resolve the possibility of variable height seems like a safe, uncontroversial resolution here. Marking as RTBC!

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented

+1 RTBC. Please commit

  • mark_fullmer committed 47e92bad on 6.0.x 
    Issue #3236385 by ricksta, mark_fullmer: Form button obscured if Layout...
mark_fullmer’s picture

mark_fullmer
he/him
Primary language English
Location Tucson
commented
Status: Reviewed & tested by the community » Fixed

Fixed! Noting that this is only an issue when using CKEditor 4, so this change at this point is really for legacy purposes (but should still be added since folks will probably be using CKEditor 4 for quite some time...)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.