Problem/Motivation

Webform libraries loaded via CDN do not work as expected via Ajax because of #1988968: Drupal.ajax does not guarantee that "add new JS file to page" commands have finished before calling said JS

Steps to reproduce

Create webform block with inputmask with Bigpipe module enabled.

Proposed resolution

Until to core issue is fixed we should change the Webform libraries CDN warning to an error in the Status report (/admin/reports/status).

Remaining tasks

Write patch
Commit patch.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#2 3236382-2.patch1.8 KBjrockowitz

Comments

jrockowitz created an issue. See original summary.

jrockowitz’s picture

jrockowitz commented
Status: Active » Needs review
StatusFileSize
new 3236382-2.patch1.8 KB

  • jrockowitz authored e029c1f on 8.x-5.x 
    Issue #3236382 by jrockowitz: Change  the Webform libraries CDN warning...
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

  • jrockowitz authored e029c1f on 6.x 
    Issue #3236382 by jrockowitz: Change  the Webform libraries CDN warning...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Anonymous’s picture

Anonymous (not verified) commented

Can someone please explain the practical impact of this error? Should I just not use AJAX on Webforms, or is it wider than that? Things seem to be working OK, do I actually have to download and install that whole list of libraries?

Thank you.

jrockowitz’s picture

jrockowitz commented

Ajax does not work as expected on a webform. This impacts webforms which use Ajax and webforms in blocks loaded via the BigPipe module (which uses Ajax).

chucksimply’s picture

chucksimply commented

This merge should be reverted. Looks like all the Ajax-related core issues have been fixed.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Have you tested 6.2.x-dev with this change reverted and confirmed that it now works correctly?

This should be done as a child ticket.