Fix codesniffer errors on CloudflareVideoFormatter

Please review the merge request.

Please see reviews. Needs work.

Uploading the patch.

Please visually review what you have done. I think you removed spaces that were needed for better readability.

I have only removed that space which is needed and detected by codesniffer.

It's good that you try to remove the whitespace, but the whitespace is added for visibility purposes. If you would go to the UI where these settings are, you would note the difference after your patch which is not desirable.
It is not just blindly changing text.

1. +++ b/src/Plugin/Field/FieldFormatter/CloudflareVideoFormatter.php
   @@ -118,13 +118,16 @@ class CloudflareVideoFormatter extends FormatterBase {
   +        '@muted' => $this->getSetting('muted') ? $this->t('muted,') : '',
   

   This should be '@muted' => $this->getSetting('muted') ? $this->('muted') . ', ' : '',

2. +++ b/src/Plugin/Field/FieldFormatter/CloudflareVideoFormatter.php
   @@ -118,13 +118,16 @@ class CloudflareVideoFormatter extends FormatterBase {
   +        '@controls' => $this->getSetting('controls') ? $this->t(', controls visible') : '',
   

   This should be '@controls' => $this->getSetting('controls') ? ', ' . $this->('controls visible') : '',

@tim-diels - Got your point. Thanks for your valuable feedback.

But if I tried your solution then it prompted with another error -
Do not concatenate strings to translatable strings, they should be part of the t() argument and you should use placeholders

So what I did now, I have given one space after @muted in line no 126. Hope that works well.

And again I ask to test this visually and not only change the code. This gives not the correct output when testing with not muted and muted, gives us extra space.

@mohit.bansal623 You're correct on the CS for concatenation.

We'll have to look for another way to display the summary. Suggestions are welcome.
My suggestion is to not display the values in a single line, but break this up over multiple lines like Drupal does for most of its fields.

Before changes:

Example:

After changes:

The text can maybe chosen better.

This looks good @pjabert. We can display like this.

Thanks for the follow up. It's much better indeed than what we now have. For me this is good to go.