Problem/Motivation

FILE: ...iew_temp/lwdalmnb/src/Plugin/Field/FieldType/CloudflareVideoItem.php
--------------------------------------------------------------------------
FOUND 18 ERRORS AND 2 WARNINGS AFFECTING 15 LINES
--------------------------------------------------------------------------
40 | ERROR | [ ] Missing @var tag in member variable comment
213 | ERROR | [ ] Public method name "CloudflareVideoItem::getZoneID"
| | is not in lowerCamel format
220 | ERROR | [ ] Public method name
| | "CloudflareVideoItem::getAccountID" is not in
| | lowerCamel format
225 | WARNING | [ ] Line exceeds 80 characters; contains 95 characters
276 | ERROR | [x] Expected newline after closing brace
294 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
308 | ERROR | [x] There must be exactly one blank line before the tags
| | in a doc comment
308 | ERROR | [ ] Missing parameter comment
308 | ERROR | [ ] Missing parameter type
309 | ERROR | [ ] Missing parameter comment
309 | ERROR | [ ] Missing parameter type
315 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: $headers
349 | ERROR | [ ] Public method name
| | "CloudflareVideoItem::getOldVideoID" is not in
| | lowerCamel format
365 | ERROR | [ ] Missing short description in doc comment
366 | ERROR | [ ] Missing parameter comment
366 | ERROR | [ ] Missing parameter type
367 | ERROR | [ ] Missing parameter comment
367 | ERROR | [ ] Missing parameter type
368 | ERROR | [ ] Description for the @return value is missing
370 | ERROR | [ ] Public method name
| | "CloudflareVideoItem::getRemovedID" is not in
| | lowerCamel format
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

pjbaert created an issue. See original summary.

mohit.bansal623 made their first commit to this issue’s fork.

mohit.bansal623’s picture

Status: Active » Needs review

Please review the merge request.

tim-diels’s picture

Status: Needs review » Needs work

This merge request is far from complete. It adds new functionality and even errors.

mohit.bansal623’s picture

Status: Needs work » Needs review

Please review the updated changes.

tim-diels’s picture

Status: Needs review » Needs work

The changes are not mergeable, so we can not test this.

@mohit.bansal623 Could you please update so we can test?

mohit.bansal623’s picture

StatusFileSize
new8.49 KB

Please review this patch.

mohit.bansal623’s picture

Status: Needs work » Needs review
tim-diels’s picture

Status: Needs review » Needs work

Patch didn't apply. So needs rework.
But already some small remarks:

  1. +++ b/src/Plugin/Field/FieldType/CloudflareVideoItem.php
    @@ -37,6 +37,8 @@ class CloudflareVideoItem extends FileItem {
    +   * @var timeout
    

    This is not correct. It gives another error. "Undefined class timeout"

    Maybe it is better to remove the $this->timeout and just specify the timeout in the function "getTimeout()"?

  2. +++ b/src/Plugin/Field/FieldType/CloudflareVideoItem.php
    @@ -86,16 +88,16 @@ class CloudflareVideoItem extends FileItem {
    +        DataDefinitionInterface $definition,
    +        ConfigFactoryInterface $config_factory,
    +        EntityTypeManagerInterface $entity_type_manager,
    +        ClientInterface $http_client,
    +        FileSystemInterface $file_system,
    +        $name = NULL,
    +        TypedDataInterface $parent = NULL,
    +        MessengerInterface $messenger = NULL,
    +        FileUsageInterface $file_usage = NULL
    +    ) {
    

    Why the change on the indent?

  3. +++ b/src/Plugin/Field/FieldType/CloudflareVideoItem.php
    @@ -117,16 +119,16 @@ class CloudflareVideoItem extends FileItem {
    +          $definition,
    +          $configFactory,
    +          $entityTypeManager,
    +          $httpClient,
    +          $fileSystem,
    +          $name,
    +          $parent,
    +          $messenger,
    +          $fileUsage
    +      );
    

    Why the change on the indent?

nikhilesh gupta’s picture

Status: Needs work » Needs review
StatusFileSize
new4.98 KB
tim-diels’s picture

Status: Needs review » Reviewed & tested by the community

Thank you for the rework. Looks good, tested and works!

  • pjbaert committed 6159036 on 8.x-2.x
    Issue #3236362 by mohit.bansal623, Nikhilesh Gupta, tim-diels, pjbaert:...
pjbaert’s picture

Status: Reviewed & tested by the community » Fixed

Thanks for all your work! This looks way cleaner now!
Pushed to the 8.x-2.x branch

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.