Closed (fixed)
Project:
Cloudflare Stream
Version:
8.x-2.x-dev
Component:
Code
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
17 Sep 2021 at 16:31 UTC
Updated:
11 Oct 2021 at 08:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #4
mohit.bansal623 commentedPlease review the merge request.
Comment #5
tim-dielsThis merge request is far from complete. It adds new functionality and even errors.
Comment #6
mohit.bansal623 commentedPlease review the updated changes.
Comment #7
tim-dielsThe changes are not mergeable, so we can not test this.
@mohit.bansal623 Could you please update so we can test?
Comment #9
mohit.bansal623 commentedPlease review this patch.
Comment #10
mohit.bansal623 commentedComment #11
tim-dielsPatch didn't apply. So needs rework.
But already some small remarks:
This is not correct. It gives another error. "Undefined class timeout"
Maybe it is better to remove the $this->timeout and just specify the timeout in the function "getTimeout()"?
Why the change on the indent?
Why the change on the indent?
Comment #12
nikhilesh gupta commentedComment #13
tim-dielsThank you for the rework. Looks good, tested and works!
Comment #15
pjbaertThanks for all your work! This looks way cleaner now!
Pushed to the 8.x-2.x branch