Problem/Motivation

As we inherit the methods from the parent class and we change nothing, we don't need the methods in our module.

Proposed resolution

Remove the methods formMultipleElements & formElement

CommentFileSizeAuthor
#7 3236312-remove_unneeded_methods_in_the_CloudflareVideoWidget-7.patch981 bytespjbaert

Issue fork cloudflare_stream-3236312

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

tim-diels created an issue. See original summary.

mohit.bansal623 made their first commit to this issue’s fork.

mohit.bansal623 opened merge request !5

mohit.bansal623’s picture

mohit.bansal623 commented
Status: Active » Needs review

Please review the merge request.

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Thank you for the merge request. I've tested this and works.

pjbaert made their first commit to this issue’s fork.

pjbaert’s picture

pjbaert
Primary language Dutch
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3236312-remove_unneeded_methods_in_the_CloudflareVideoWidget-7.patch981 bytes

I was trying to fix this trough Gitlab, since a rebase was needed but I messed up.
Please review this oldschool patch :)

tim-diels’s picture

tim-diels
He/Him
Primary language Dutch
Location Belgium 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Woops something did went wrong there. But the patch looks good.

  • pjbaert committed 2d2b485 on 8.x-2.x 
    Issue #3236312 by pjbaert, mohit.bansal623, tim-diels: Remove unneeded...
pjbaert’s picture

pjbaert
Primary language Dutch
commented
Status: Reviewed & tested by the community » Fixed

Uhum. Let's quickly push this one to dev 😉
Thanks for your initial work @mohit.bansal623 & thank you for reviewing @tim-diels!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

pjbaert closed merge request !5