Problem/Motivation

Noticed that GinSettings::getAdminTheme() uses the \Drupal global static class rather than dependency injection, despite the fact that the class uses dependency injection for other stuff.

Steps to reproduce

Look at the code. :P

Proposed resolution

Inject the config.factory service and use that instead.

Remaining tasks

See previous point.

User interface changes

None.

API changes

None probably?

Data model changes

Unsure, don't think so?

Issue fork gin-3236178

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Ambient.Impact created an issue. See original summary.

Ambient.Impact opened merge request !50

ambient.impact’s picture

ambient.impact
they/them
Primary language English
Location Toronto
commented
Status: Active » Needs review

saschaeggi made their first commit to this issue’s fork.

ambient.impact’s picture

ambient.impact
they/them
Primary language English
Location Toronto
commented

🙌🎉

inaw’s picture

inaw commented
Status: Needs review » Reviewed & tested by the community

The implementation of the dependency injection for config.factory looks correct to me.
I was also able to successfully test the MR with Gin 8.x-3.0-alpha37 and 8.x-3.x-dev

saschaeggi’s picture

saschaeggi
he/him
commented
Status: Reviewed & tested by the community » Fixed

Thanks both!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.