Problem/Motivation

Method "Symfony\Component\Validator\Mapping\Factory\MetadataFactoryInterface::getMetadataFor()" will return "MetadataInterface" as of its next major version. Doing the same in implementation "Drupal\Core\TypedData\Validation\RecursiveValidator" will be required when upgrading.

Method "Symfony\Component\Validator\Mapping\Factory\MetadataFactoryInterface::hasMetadataFor()" will return "bool" as of its next major version. Doing the same in implementation "Drupal\Core\TypedData\Validation\RecursiveValidator" will be required when upgrading.

Steps to reproduce

Proposed resolution

Add the return type hints.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3233481-2.patch1.47 KBdaffie
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

daffie created an issue. See original summary.

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Active » Needs review
FileSize
3233481-2.patch1.47 KB

I could not find any instances where the methods are overridden in contrib. See: http://grep.xnddx.ru/search?text=public+function+getMetadataFor%28&filen... and http://grep.xnddx.ru/search?text=public+function+hasMetadataFor%28&filen...

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave at Full Fat Things commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

  • larowlan committed 95c9835 on 9.3.x 
    Issue #3233481 by daffie: [Symfony 6] Add type hints to the methods...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Committed 95c9835 and pushed to 9.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.