Problem/Motivation

Method "Symfony\Component\Validator\Context\ExecutionContextFactoryInterface::createContext()" will return "ExecutionContextInterface" as of its next major version. Doing the same in implementation "Drupal\Core\TypedData\Validation\ExecutionContextFactory" will be required when upgrading.

Steps to reproduce

Proposed resolution

Add the "ExecutionContextInterface" return type hint.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3233464-2.patch995 bytesdaffie

Comments

daffie created an issue. See original summary.

daffie’s picture

daffie commented
Status: Active » Needs review
StatusFileSize
new 3233464-2.patch995 bytes

I could not find any instances where contrib is overriding the method. See: http://grep.xnddx.ru/search?text=ExecutionContextFactory&filename=.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community

Maybe we can deprecate this in #3231683: [Symfony 6] A number of methods of the class Drupal\Core\TypedData\Validation\ExecutionContext are considered internal and Drupal should not override them., in the meantime this will work.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed c1831be and pushed to 9.3.x. Thanks!

  • larowlan committed c1831be on 9.3.x 
    Issue #3233464 by daffie: [Symfony 6] Add "ExecutionContextInterface"...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.