The ldap_sso was split out from the ldap module 2 years ago and with its D8/D9 stabilization, I'm applying now for security coverage for it, after having maintained it (and its parent ldap) since then.

Project link

https://www.drupal.org/project/ldap_sso

Git instructions

git clone --branch '8.x-4.x' https://git.drupalcode.org/project/ldap_sso.git

PAReview checklist

http://pareview.net/r/466

Comments

grahl created an issue. See original summary.

grahl’s picture

grahl
he/him
Location Zürich
commented
Issue summary: View changes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
anoopjohn’s picture

anoopjohn commented
Issue summary: View changes

Ran a PAReview test on the project 8.x branch and updated desc with link

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Reviewed & tested by the community 
  /**
   * Config.
   *
   * @var \Drupal\Core\Config\Config|\Drupal\Core\Config\ImmutableConfig
   */
  protected $config;

  /**
   * The current user account.
   *
   * @var \Drupal\Core\Session\AccountInterface
   */
  protected $account;

Those values are already provided by the parent class. The class constructor needs to be changed too.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Assigned: Unassigned » avpaderno
Status: Reviewed & tested by the community » Fixed

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.