[Symfony 6] Add "array" type hint to methods overriding Symfony\Component\EventDispatcher\EventSubscriberInterface::getSubscribedEvents()

We should be OK to commit a patch for all the non-base classes in Drupal 9. The base classes will need to wait for Drupal 10 though.

We should be OK to commit a patch for all the non-base classes in Drupal 9. The base classes will need to wait for Drupal 10 though.

Agree

Needs work to handle the non-base classes here and a new issue to postpone the base classes until Drupal 10.

The abstract classes that implement this method are:

core/lib/Drupal/Core/Config/ConfigFactoryOverrideBase.php:abstract class ConfigFactoryOverrideBase implements EventSubscriberInterface {
core/lib/Drupal/Core/Config/ConfigImportValidateEventSubscriberBase.php:abstract class ConfigImportValidateEventSubscriberBase implements EventSubscriberInterface {
core/lib/Drupal/Core/EventSubscriber/HttpExceptionSubscriberBase.php:abstract class HttpExceptionSubscriberBase implements EventSubscriberInterface {
core/lib/Drupal/Core/Routing/RouteSubscriberBase.php:abstract class RouteSubscriberBase implements EventSubscriberInterface {

I reverted these changes from the patch so only concrete classes remain. I agree with #3/#4 that extending existing event subscribers is likely a non-standard thing to do and so we should be able to commit this to 9.4.x.

#2 can go into 10.0.x as it changes all classes, #8 should be able to go into 9.4.x as it changes concrete classes only.

Sent #2 for a retest, think that was from when 10.x testing was broken.

Agreed both patches look ready.

Committed 1359e7a and pushed to 10.0.x. Thanks!

I've committed #2 to 10.0.x

I think we need a little bit more discussion about committing #8 to 9.4.x. I'm not sure because I know people do extend events and potentially override getSubscribedEvents... see http://grep.xnddx.ru/search?text=parent%3A%3AgetSubscribedEvents&filename=

Personally I think we should only make this change in Drupal 10 to give people a chance to update their code because if they extend core and add the return typehint they can be 9 & 10 compatible. Setting back to needs review for more discussion.

I think we should mark this fixed for 10.0.x, then re-open for backport if we discover a reason to.