We have a couple usages of --color--blue-50 in text (see the RSS icon's hover state). We need to make sure we're not using these as it doesn't provide a 4.5:1 contrast ratio required to be WCAG compliant.

In #3211616: Olivero: a11y color contrast test fail for primary button on hover we introduce a new variable --color--blue-10. We can use that, or the existing --color--blue-20 variable.

CommentFileSizeAuthor
#2 3231744-2.patch43.22 KBgauravvvv

Issue fork drupal-3231744

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mherchel created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new 3231744-2.patch43.22 KB

Replaced the color variable--color--blue-50 with --color--blue-10 in patch #2, Please review.

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Needs work

We don't need to make the change everywhere, only where it doesn't meet contrast criteria. This means we don't need to change borders, outlines, etc. We also don't need to change it if the text is larger than 19px bold too.

Gauravmahlawat opened merge request !1177

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented

As part if #3242469: Insufficient contrast on Olivero's inactive vertical form labels, we also need to make sure that the new text color provides sufficient contrast in the inactive vertical form labels.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

MR needs to be updated to 10.1 please.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue tags: +WCAG 143

Adding tag for WCAG SC 1.4.3

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Needs work » Postponed

The Olivero theme was approved for removal in #3590816: [policy, no patch] Deprecate Olivero and move to contrib.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3595082: [meta] Tasks to deprecate the Olivero theme and the removal work in #3595085: [meta] Tasks to remove the Olivero theme.