Problem/Motivation

Method "Symfony\Component\DependencyInjection\ContainerBuilder::setAlias()" will return "Alias" as of its next major version. Doing the same in child class "Drupal\Core\DependencyInjection\ContainerBuilder" will be required when upgrading.

Steps to reproduce

Proposed resolution

Add the "Alias" type hint.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3231669-2.patch973 bytesdaffie
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

daffie created an issue. See original summary.

daffie’s picture

daffie CreditAttribution: daffie commented
Status: Active » Needs review
FileSize
3231669-2.patch973 bytes

The fix.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Needs review » Reviewed & tested by the community

Lots of references to ContainerBuilder in contrib, but they all look to be instantiating or type hinting, not subclassing.

http://grep.xnddx.ru/search?text=ContainerBuilder&filename=

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan at PreviousNext commented
Status: Reviewed & tested by the community » Fixed

Committed 6e7cd2e and pushed to 9.3.x. Thanks!

  • larowlan committed 6e7cd2e on 9.3.x 
    Issue #3231669 by daffie: [Symfony 6] Add "Alias" type hint to Drupal\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.