Problem/Motivation

 1x: Method "Symfony\Component\BrowserKit\AbstractBrowser::doRequest()" will return "object" as of its next major version. Doing the same in child class "Drupal\Tests\DrupalTestBrowser" will be required when upgrading.

Steps to reproduce

Proposed resolution

Add the object type hint.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3231390-1.patch555 bytescatch

Comments

catch created an issue. See original summary.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new 3231390-1.patch555 bytes
daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

In the testbot run with the MR with Symfony 5.4 and without the change of this patch there where more 4 deprecation messages for "Symfony\Component\BrowserKit\AbstractBrowser::doRequest()". See: https://www.drupal.org/pift-ci-job/2168133.
For the same MR with Symfony 5.4 and the change of this patch all those deprecation message where gone. See: https://www.drupal.org/pift-ci-job/2170145. Therefor for me RTBC.

daffie’s picture

daffie commented
Priority: Normal » Critical
Issue tags: +Drupal 10

Part of the Symfony 6 in D10 initiative.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Nothing extends this in contrib http://grep.xnddx.ru/search?text=extends+DrupalTestBrowser&filename=

Adding to the change notice.

Committed 15c98f6 and pushed to 9.3.x. Thanks!

  • larowlan committed 15c98f6 on 9.3.x 
    Issue #3231390 by catch, daffie: [symfony 6] Add an object return type...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.