Closed (fixed)
Project:
Leaflet More Maps
Version:
2.1.2
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
2 Sep 2021 at 21:23 UTC
Updated:
1 Oct 2024 at 22:00 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
berramou commentedhello @RdeBoer
if we could add the hook proposed here https://www.drupal.org/project/leaflet_more_maps/issues/3089020 everyone can add their maps.
Comment #3
rdeboer@bachbach
Thanks for the patch!
@berramou
Happy for you to go ahead with it. Please document it well, because as discussed in #3089020: Add hook to give custom modules possibility to add other maps to default list. there will be 2 different hooks and this may confuse some.
Comment #4
berramou commentedHello @RdeBoer
The hook
hook_leaflet_map_info_altercome from the leaflet module not from our module.Here https://git.drupalcode.org/project/leaflet/-/blob/2.1.x/leaflet.api.php#...
Comment #5
berramou commentedComment #6
bachbach commentedi know there is now a hook, but did not have time to create a new module, here my patch against 2.1.3
Comment #7
berramou commentedHello @bachbach
thank you for your patch and for your understanding, i guess it's better to let developers add their own maps to the list it's practical otherwise each new map it require user create an issue add new tiles to the list push create new release ....
And the .module file will become huge file and hard to maintain.
Thank you @bachbach for your understanding.
I'm waiting for other maintainers to review and improve or accept this patch.
Comment #8
berramou commentedI close this issue as fixed, since now the module propose a hook that let developers add their maps #3089020: Add hook to give custom modules possibility to add other maps to default list.
Comment #9
berramou commentedComment #10
berramou commented