It is unnecessary work for a site builder to check the Safe truncate html option for every formatted text field in order to get a character count. Instead, that should happen for all formatted text fields.
In the code, detect whether a field uses formatted text. If so, skip HTML markup in the character count.
Remove the Safe truncate html option from the interface.
| Comment | File | Size | Author |
|---|
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
cedeweyComment #3
cedeweyComment #4
cedeweyComment #5
cedeweyWe invite Drupal users to participate in our poll about this
Drupal Slack - https://drupal.slack.com/archives/C1AFW2ZPD/p1642796032021600
Fediverse (eg: Mastodon) - https://social.coop/web/statuses/107662309391153132
Twitter - https://twitter.com/claybolto/status/1484623479592861697
Comment #6
cedeweyComment #7
cedeweyNo one participated in either of the three polls so we're interpreting that as people are ok doing away with this configuration setting and assuming people want HTML tags ignored in the character count.
Comment #8
boehmrya commentedJust to add my thoughts - I agree with doing away with this configuration. I know that my impression was always that the maxlength setting should apply strictly to characters, and not include html. I imagine most people would interpret the setting in a similar way.
The one situation (that I can think of) where this may be confusing is when you have a formatted text field (as opposed to a long text field), where the html is clearly visible in the form (no wysiwyg editor). So, it may be worth adding some help text clarifying that the maxlength setting does not count html tags in formatted text fields.
I'll assign this task to myself, and work on a patch.
Comment #9
boehmrya commentedSorry - I haven't had as much time to work on this recently, so i'm going to unassign it from myself.
Comment #10
hipp2bsquare commentedI'll take this on as my next task.
Comment #12
hipp2bsquare commentedClayton -- I've put in a merge request for my work automatically performing safe truncate on all HTML fields (see above). Please test for usability/bugs, then turn over to Steven for code review.
Comment #14
cedeweyI've tested this and works as expected from an editing perspective. Assigning to Steven for code review.
Comment #15
srdtwc commented