Problem/Motivation

The extended class CommerceBrowserTestBase has updated their setUp() declaration, please see

Since EmailRegistrationLoginTest::setUp is not yet compatible with that, it's resulting in the following error:

PHP Fatal error:  Declaration of Drupal\Tests\email_registration\Functional\Plugin\Commerce\CheckoutPane\EmailRegistrationLoginTest::setUp() must be compatible with Drupal\Tests\commerce\Functional\CommerceBrowserTestBase::setUp(): void in /app/web/modules/contrib/email_registration/tests/src/Functional/Plugin/Commerce/CheckoutPane/EmailRegistrationLoginTest.php on line 308

Steps to reproduce

phpunit web/modules/contrib/email_registration/tests/src/Functional/Plugin/Commerce/CheckoutPane/EmailRegistrationLoginTest.php

Proposed resolution

Make EmailRegistrationLoginTest::setUp compatible to CommerceBrowserTestBase::setUp

Remaining tasks

Create & attach the patch.

User interface changes

N/A

API changes

N/A

Data model changes

N/A

CommentFileSizeAuthor
#3 email_registration-update-the-emailregistrationlogintest-3228033-3.patch625 bytesrishi.kulshreshtha

Comments

Rishi Kulshreshtha created an issue. See original summary.

rishi.kulshreshtha’s picture

rishi.kulshreshtha
He/Him
Primary language English
Location Portland, Maine
commented
Issue summary: View changes
rishi.kulshreshtha’s picture

rishi.kulshreshtha
He/Him
Primary language English
Location Portland, Maine
commented
Title: Update the EmailRegistrationLoginTest test to match the parent CommerceBrowserTestBase class. » Update the EmailRegistrationLoginTest to match the parent CommerceBrowserTestBase class.
Assigned: rishi.kulshreshtha » Unassigned
Status: Active » Needs review
StatusFileSize
new email_registration-update-the-emailregistrationlogintest-3228033-3.patch625 bytes
siegrist’s picture

siegrist
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Looks good, thanks for the patch.

lkacenja’s picture

lkacenja
he/him
commented

This makes sense and seems great to me!

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented

Tests pass. This looks like the reason tests are not shown passing on the module page for 8.x-1.1.

- https://www.drupal.org/node/182476/qa
- https://dispatcher.drupalci.org/job/drupal_contrib/538409/console

In reviewing this and other module options, seeing that tests are green for the proposed version of the module is a useful assessment criteria.

Can the community do anything further to help this patch land?

  • andypost committed 0f77131 on 8.x-1.x 
    Issue #3228033 by Rishi Kulshreshtha: Update the...
andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Reviewed & tested by the community » Fixed
Related issues: +#3297059: Automated Drupal 10 compatibility fixes

Thank you fixed!

Great addition to D10 fixes #3297059: Automated Drupal 10 compatibility fixes

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.