Problem/Motivation

Xss::filterAdmin() is currently stripping out the button tag and it has a big affliction on accessibility because interactive elements are not following on another page or anchor.

Proposed resolution

$adminTags sets would need to be updated with one more tag - 'button'.

CommentFileSizeAuthor
#5 interdiff_2-5.txt2.49 KBrahulkhandelwal1990
#5 3226412-5.patch1.65 KBrahulkhandelwal1990
xss_admin_tags_button.patch1.65 KBmialdi98

Comments

mialdi98 created an issue. See original summary.

cilefen’s picture

cilefen commented
Status: Active » Needs review

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

joachim’s picture

joachim commented
Category: Feature request » Bug report
Status: Needs review » Needs work
Issue tags: +Needs tests, +Needs issue summary update, +Accessibility

The elements in that string look like they are in alphabetical order.

Also, this sounds like it needs tests for the accessibility problem -- which I don't understand, so the IS could do with expanding.

If it's an accessibility problem, though, then it's a bug.

rahulkhandelwal1990’s picture

rahulkhandelwal1990 commented
Status: Needs work » Needs review
StatusFileSize
new 3226412-5.patch1.65 KB
new interdiff_2-5.txt2.49 KB

Rearrange alphabetically

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

maxmendez’s picture

maxmendez commented

Tested patch #5 and works fine. Thanks for your work!

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Moving back to NW for the tests and issue summary mentioned in #4

mgifford’s picture

mgifford
he/him
Primary language English
commented

Any idea what WCAG SC this might be tied to? I don't understand the issue well enough.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs work » Postponed (maintainer needs more info)

This needs more information please, #10 mentioned needing to know what rule this is breaking

smustgrave’s picture

smustgrave commented
Status: Postponed (maintainer needs more info) » Closed (outdated)

Since there's been no follow up to how this is an accessibility issue I'm going to close out. If still valid please re-open and update summary with how this is an accessibility issue please

Thanks all!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.