Claro: Move svg image from template to images folder. [#3226309]

Problem/Motivation

Claro: Move svg image from templates to images folder.

drupal/core/themes/claro/templates/admin/indentation.html.twig from this file

<svg
    xmlns="http://www.w3.org/2000/svg"
    class="tree"
    width="25"
    height="25"
    viewBox="0 0 25 25">
    <path
      class="tree__item tree__item-child-ltr tree__item-child-last-ltr tree__item-horizontal tree__item-horizontal-right"
      d="M12,12.5 H25"
      stroke="#888"/>
    <path
      class="tree__item tree__item-child-rtl tree__item-child-last-rtl tree__item-horizontal tree__horizontal-left"
      d="M0,12.5 H13"
      stroke="#888"/>
    <path
      class="tree__item tree__item-child-ltr tree__item-child-rtl tree__item-child-last-ltr tree__item-child-last-rtl tree__vertical tree__vertical-top"
      d="M12.5,12 v-99"
      stroke="#888"/>
    <path
      class="tree__item tree__item-child-ltr tree__item-child-rtl tree__vertical tree__vertical-bottom"
      d="M12.5,12 v99"
      stroke="#888"/>
  </svg>

Steps to reproduce

1. example : Go to admin/structure/menu/manage/admin
2. Check below menu link Here you can see parent and child link.
3. You can see space before the child menu. If you inspect you can see the svg tag.

Proposed resolution

Remove the svg tag code from the drupal/core/themes/claro/templates/admin/indentation.html.twig file and create a new svg file in the images folder.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

Comment	File	Size	Author
#26	Screenshot 2024-10-04 at 6.25.29 AM.png	32.36 KB	bnjmnm
#26	Screenshot 2024-10-04 at 6.28.13 AM.png	21.54 KB	bnjmnm
#19	Screenshot 2024-08-20 at 5.07.25 PM.png	1.57 MB	shweta__sharma
#18	Screenshot from 2024-08-14 20-44-13.png	141.41 KB	sagarmohite0031
#18	Screenshot from 2024-08-14 20-44-09.png	179.79 KB	sagarmohite0031
#16	3226309-nr-bot.txt	2.34 MB	needs-review-queue-bot
#15	AfterMR.png	83.73 KB	kanchan bhogade
#15	BeforeMR.png	80.59 KB	kanchan bhogade
#14	Indentation.png	70.08 KB	ahsannazir
#13	Screenshot from 2024-07-16 18-16-56.png	108.89 KB	bhumikavarshney
#8	Screenshot from 2024-07-05 17-27-03.png	51.7 KB	sanket.tale
#8	Screenshot from 2024-07-05 17-20-58.png	51.52 KB	sanket.tale

Issue fork drupal-3226309

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

1 hidden branch

3226309-claro-move-svg

changes, plain diff MR !8672

Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

2 August 2021 at 13:12

Gauravmahlawat created an issue. See original summary.

Comment #2

2 August 2021 at 13:12

Version:

9.3.x-dev

» 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #3

2 August 2021 at 13:12

Version:

9.4.x-dev

» 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #4

2 August 2021 at 13:12

Version:

9.5.x-dev

» 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #5

2 August 2021 at 13:12

Version:

10.1.x-dev

» 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Comment #6

5 July 2024 at 10:16

sanket.tale made their first commit to this issue’s fork.

Comment #7

5 July 2024 at 10:55

sanket.tale opened merge request !8672

Comment #8

sanket.tale commented 5 July 2024 at 11:58

Issue summary:	View changes
Status:	Active	» Needs review

Status	File	Size
new	Screenshot from 2024-07-05 17-20-58.png	51.52 KB
new	Screenshot from 2024-07-05 17-27-03.png	51.7 KB

Created MR for the issue please review it.

Steps to reproduce

example : Go to admin/structure/menu/manage/admin
Check below menu link Here you can see parent and child link.
You can see the space before the child menu. If you inspect before the MR you can see the svg tag and after the MR you can see the ::before pseudo element.

Before :-

After :-

Comment #9

sanket.tale commented 5 July 2024 at 12:01

Issue summary:

View changes

Comment #10

smustgrave commented 11 July 2024 at 13:26

Status:	Needs review	» Needs work
Issue tags:		+Needs issue summary update, +Needs subsystem maintainer review

Issue summary should follow standard template.

Also may need submaintainer sign off

Comment #11

sanket.tale commented 12 July 2024 at 06:05

Title:	Claro: Move svg image from templates to images folder	» Claro: Move svg image from template to images folder.
Issue summary:	View changes

Comment #12

sanket.tale commented 12 July 2024 at 06:55

Status:

Needs work

» Needs review

Comment #13

bhumikavarshney commented 16 July 2024 at 17:33

Status	File	Size
new	Screenshot from 2024-07-16 18-16-56.png	108.89 KB

The issue mentioned that svg image code drupal/core/themes/claro/templates/admin/indentation.html.twig added in this template need to be moved to image folder.

But this merge request https://git.drupalcode.org/project/drupal/-/merge_requests/8672/diffs?co... added the same svg by pseudo element.

So need more information do we need to include svg from img tag by using the image source in the url.

As you can refer the
Proposed resolution
Remove the svg tag code from the drupal/core/themes/claro/templates/admin/indentation.html.twig file and create a new svg file in the images folder.

Comment #14

ahsannazir commented 17 July 2024 at 07:38

Status	File	Size
new	Indentation.png	70.08 KB

The SVG code has been removed from twig file and SVG has been moved to images/src folder.

Comment #15

kanchan bhogade commented 17 July 2024 at 12:43

Status	File	Size
new	BeforeMR.png	80.59 KB
new	AfterMR.png	83.73 KB

Hi
I've tested MR 8672 on Drupal 11.x
MR is applied cleanly...

Test Result:
The SVG code has been removed from the twig file.

Attaching SS for reference

Comment #16

needs-review-queue-bot commented 24 July 2024 at 08:54

Status:

Needs review

» Needs work

Status	File	Size
new	3226309-nr-bot.txt	2.34 MB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Comment #17

sanket.tale commented 24 July 2024 at 10:37

Status:

Needs work

» Needs review

Comment #18

sagarmohite0031 commented 14 August 2024 at 15:16

Assigned:

Unassigned

» sagarmohite0031

Status	File	Size
new	Screenshot from 2024-08-14 20-44-09.png	179.79 KB
new	Screenshot from 2024-08-14 20-44-13.png	141.41 KB

I have tried to apply MR !8672 but MR is failing.

Please check Error screenshot.

Comment #19

shweta__sharma commented 20 August 2024 at 11:38

Status	File	Size
new	Screenshot 2024-08-20 at 5.07.25 PM.png	1.57 MB

I have applied MR 8672, but when I try to apply it locally, I receive an error. Attached a screenshot.

Comment #20

shweta__sharma commented 20 August 2024 at 11:39

Status:

Needs review

» Needs work

Comment #21

sanket.tale commented 28 August 2024 at 07:15

Status:

Needs work

» Needs review

Comment #22

sanket.tale commented 28 August 2024 at 07:34

Status:

Needs review

» Needs work

Comment #23

sanket.tale commented 6 September 2024 at 07:00

Status:

Needs work

» Needs review

Comment #24

smustgrave commented 20 September 2024 at 14:03

Assigned:

sagarmohite0031

» Unassigned

Comment #25

smustgrave commented 3 October 2024 at 14:16

Issue tags:

-Needs issue summary update

Comment #26

bnjmnm

he/him

English

Ann Arbor, MI

commented 4 October 2024 at 10:32

Status:

Needs review

» Closed (works as designed)

Status	File	Size
new	Screenshot 2024-10-04 at 6.28.13 AM.png	21.54 KB
new	Screenshot 2024-10-04 at 6.25.29 AM.png	32.36 KB

This is intentionally added as an SVG document so it can receive CSS styling. This is responsible for the lines that show the relationship between tabledrag items that are seen while dragging. It functions as dynamic element in the UI, not just a background image.

Without the css to conditionally hide/show portions of the SVG this either results in losing the lines altogether or having ALL the lines visible at all times we don't want this 👇 (nor do we want those lines to be removed entirely)