Problem/Motivation

Claro: trans filter missing to static text in /drupal/core/themes/claro/templates/status-report-counter.html.twig file.

Syntax is <span class="system-status-counter__details"><a href="#{{ severity }}" ><span class="visually-hidden">{{ text }} </span>Details</a></span>

Details text should be in the trans filter

Suggestion

Syntax is <span class="system-status-counter__details"><a href="#{{ severity }}" ><span class="visually-hidden">{{ text }} </span>{{ 'Details'|t }}</a></span>

CommentFileSizeAuthor
#22 3226250-22.patch2.19 KBheni_deepak
#21 3226250-21.patch3.61 KBheni_deepak
#6 3226250-6.patch3.61 KBsaidatom
#2 3226250-2.patch889 bytesgauravvvv

Issue fork drupal-3226250

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Gauravmahlawat created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
StatusFileSize
new 3226250-2.patch889 bytes

Patch attached with suggested solution, Please review.

kostyashupenko’s picture

kostyashupenko
Primary language English
Location Omsk
commented
Status: Needs review » Reviewed & tested by the community

Patch looks great

heni_deepak’s picture

heni_deepak commented

Patch looks great and also needs to apply on seven admin themes.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 3226250-2.patch, failed testing. View results

saidatom’s picture

saidatom
Location Lisbon
commented
StatusFileSize
new 3226250-6.patch3.61 KB

Patch attached with all themes.

saidatom’s picture

saidatom
Location Lisbon
commented
Status: Needs work » Needs review
heni_deepak’s picture

heni_deepak commented

Patch #6 is well for all admin themes. hopefully, it will commit in Drupal newer version.

saidatom’s picture

saidatom
Location Lisbon
commented
Status: Needs review » Reviewed & tested by the community

Based in #8

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 6: 3226250-6.patch, failed testing. View results

Gauravmahlawat opened merge request !1142

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review
saidatom’s picture

saidatom
Location Lisbon
commented
Status: Needs review » Reviewed & tested by the community

Thanks! Looks good to me, this is now in RTBC.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs issue summary update, +Needs frontend framework manager review

It looks like this impacts more than Claro - can we get an issue title and summary update?

Tagging for front end framework manager review, as technically templates in stable shouldn't change, although I think this would be allowed.

Is there anything we can do here to add test coverage for this?

heni_deepak’s picture

heni_deepak commented
Title: Claro: trans filter missing to static text in status-report-counter.html.twig file » status report counter text need to be translatable ( status-report-counter.html.twig )
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Status

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Needs review
Issue tags: -Needs issue summary update

> Is there anything we can do here to add test coverage for this?

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Needs frontend manager review
Needs (possible) tests
Also patch is targetting seven which is removed in D10

heni_deepak’s picture

heni_deepak commented
StatusFileSize
new 3226250-21.patch3.61 KB

Reroll the patch with 9.5.x

heni_deepak’s picture

heni_deepak commented
StatusFileSize
new 3226250-22.patch2.19 KB

reload patch with 10.1.x-dev

gauravvvv’s picture

gauravvvv commented

Updating attributions.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Gauravvvv changed the visibility of the branch 3226250-claro-trans-filter to hidden.

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Closed (duplicate)
Related issues: +#3350526: trans filter is missing on text in status-report-counter.html.twig file