Claro: Update the URL's which are still using http and they have shifted to https

CommentFileSizeAuthor
#12 find-http.jpeg94.04 KBilgnerfagundes
#9 interdiff_7-9.txt24.78 KBvsujeetkumar
#9 3226055-9.patch36.05 KBvsujeetkumar
#7 interdiff-3-7.txt847 byteskishor_kolekar
#7 3226055-7.patch6.65 KBkishor_kolekar
#4 3226055-3.patch5.67 KBgauravvvv
#2 3226055-2.patch6.19 KBgauravvvv

Comments

Gauravmahlawat created an issue. See original summary.

gauravvvv’s picture

gauravvvv commented
Status: Active » Needs review
StatusFileSize
new 3226055-2.patch6.19 KB

I have updated all the URL's which have been shifted to https and still using http in our templates. Added a patch for same. Please review.

Status: Needs review » Needs work

The last submitted patch, 2: 3226055-2.patch, failed testing. View results

gauravvvv’s picture

gauravvvv commented
StatusFileSize
new 3226055-3.patch5.67 KB

Patch updated.

gauravvvv’s picture

gauravvvv commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: 3226055-3.patch, failed testing. View results

kishor_kolekar’s picture

kishor_kolekar commented
Status: Needs work » Needs review
StatusFileSize
new 3226055-7.patch6.65 KB
new interdiff-3-7.txt847 bytes

please review the patch.

Status: Needs review » Needs work

The last submitted patch, 7: 3226055-7.patch, failed testing. View results

vsujeetkumar’s picture

vsujeetkumar commented
Status: Needs work » Needs review
StatusFileSize
new 3226055-9.patch36.05 KB
new interdiff_7-9.txt24.78 KB

Fixed the fail test, Updated all the remaining URL's which have been shifted to https.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

cilefen’s picture

cilefen commented
Category: Support request » Task
Issue tags: +Documentation

This looks like it was mis-categorized as a support request.

ilgnerfagundes’s picture

ilgnerfagundes commented
Status: Needs review » Needs work
StatusFileSize
new find-http.jpeg94.04 KB

Hey guys, I was doing the review and I saw two things, the first was that the patch is covering more than just the clear topic. I don't know if this is a problem as I would be making a more complete change, but the second point I saw was that in the other themes it didn't switch to https on all urls. For example in the file

/drupal/core/themes/stable/templates/admin/field-ui-table.html.twig

on line 13
or in the

/drupal/core/themes/starterkit_theme/templates/media-library/links--media-library-menu.html.twig

file on line 13

I attached an image showing a search I did for http:// and it had some results

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Needs work » Closed (outdated)
Issue tags: -Documentation

Changing a pattern like this should be done throughout the code base with a Meta issue to scope the child issues sensibly. We would not scope by theme or module. How this is being done can be seen in #3399840: [meta] Replace http urls with https urls of the respective sites in core

I am closing this as outdated.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

quietone’s picture

quietone commented
Title: Claro: Update the URL's which are still using http and they have shifted to https » Update the URL's which are still using http and they have shifted to https