Preserve query parameters and fragments when directly inputting a path.

Wasn't this fixed in #2895153: Linkit filter should honour the URL query and fragment?

The issue title mentions query parameters are stripped from the input URL, but the issue summary mentions the query parameters are stripped from the suggestion paths. What exactly is being fixed here?

Hey,

I can confirm that preserving query parameters was reported as expected behaviour from a client and applying this patch solves it.

Details:

• Drupal: 9.2.6
• Linkit: 6.0.0-beta3
• php: 7.4.19
• MariaDB: 10.5.10

Please do let me know if you need more details regarding the case and I'll try to comeback to you asap.

Cheers!
Stefan

I can confirm linkit is not removing the query parameter from the field even after clicking on the suggestion.

Details:

1. Drupal: 9.3.3
2. Linkit: 6.0.0-beta3
3. php: 7.4.27

I don't think the proposed solution is ok because it is saving the query and fragment in the uri. That is not compatible with the core link schema or other modules that use the core link schema.
I propose saving the query and fragment in the options base field of the link field as described in the core link schema.
My solution only works with the patch from this issue on linkit_field https://www.drupal.org/project/linkit_field/issues/3349013
because the linkit widget from linkit doesn't use the node path/alias.

The previous patch is incomplete. I appologize!
I uploaded a new one (it is based on the patch from #7).

My solution only works with the patch from this issue on linkit_field

Just a note that recently #2712951: Linkit for Link field was merged into the 6.0.x branch, so a patch that addresses this for the link field context can build on that foundation.

Note that the equivalent issue reported on the 6.x branches for this module has been fixed in #3359375: Query fragments or anchors on internal URLs in link fields get lost on re-editing.

As is practicable, sites should update to 6.x rather than continuing to use 8.x-5.x

Update: upon revisiting this now, my analysis in #18 is incorrect. *This* issue describes a different request than was dealt with in #3359375: Query fragments or anchors on internal URLs in link fields get lost on re-editing. Setting this to track the current development branch for Linkit.

I've added an MR that is based on the patch from #16 that applies to the 7.x branch. Setting back to needs review based on the change between #14 and #16.

This introduces test failures, per https://git.drupalcode.org/project/linkit/-/jobs/5001403 . Setting back to "Needs work."

Snapshot of latest state of MR for usage with composer patches

I've updated the MR with the latest changes from 7.x. The test failures from #22 are resolved. Attached is a snapshot of the current state of the MR, so it can be safely used with composer-patches.

I've used Claude Code to debug the CI failures.

\Drupal\linkit\Plugin\Linkit\Matcher\FrontPageMatcher::getQueryAndFragment can be replaced with \Drupal\linkit\Utility\LinkitHelper::getQueryAndFragment now that #2712951: Linkit for Link field is committed

#28 is addressed in the MR, thanks.

Looks good to me! I'll mark this RTBC so @mark_fullmer has the chance to take a second look before commit

This all looks good to me. Thanks everyone for the work, and especially @timohuisman for updating the MR and @idebr for the review!