Closed (fixed)
Project:
Upgrade Status
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
13 Jul 2021 at 14:38 UTC
Updated:
25 Jan 2022 at 08:41 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
gábor hojtsyWhat should the exact messaging be?
Comment #4
gábor hojtsySo Drupal 9.2 and before will of course not have the ExtensionLifecycle object, so we need to hardcode the values. Drupal 8 projects will not have this key, so I don't think we need to try to limit this feature to Drupal 9 only. If Drupal 8 contribs decide to adopt the key even though no core support, they would have this added reporting which I don't think is a problem.
Comment #5
gábor hojtsyAdding tests.
Also realized while working on tests that installed but obsolete or deprecated core modules will not be detected by the general detector, since we ignore core for the sake of upgrade status. So we'll need to add that to the environment checks. Added a todo for that.
Comment #7
gábor hojtsyIt helps if the test modules are in the patch :D
Comment #8
gábor hojtsyIncluded some residue.
Comment #10
gábor hojtsyAlso it helps to name them info.yml 🤦
Comment #11
gábor hojtsySo we have proof that detecting contrib deprecated and obsolete modules works. The core part still needs to be covered as per the @todo, and I don't think we have a core module we can test against, so that part is probably not testable automatically. (Unless we change the info data at runtime, hm).
Comment #12
gábor hojtsyAdding core project check to the environment checks, extension collection to the project collector.
Comment #13
gábor hojtsyOther than the text this is technically ready I think.
Comment #14
gábor hojtsyUpdated based on #3225812: Add lifecycle_link key to info.yml files and following discussion about what to say about obsolete modules. Most of the time they don't need user action. This should be good if green.
Comment #16
gábor hojtsyMissed some files.
Comment #18
gábor hojtsyComment #20
gábor hojtsyObsolete module detection cannot be tested because now Drupal blocks enabling obsolete modules. Recently noticed in module fails. Opened #3260292: Fix tests: obsolete module detection cannot be tested because now Drupal blocks enabling obsolete modules; Drupal 9.3.0's release necessitated mock deprecation changes for categorization accuracy.