Add the following tag from #3116138: Facebook catalog tags - product:retailer_item_id (D7):

product:retailer_item_id

It also needs to be added to the test and the migration path.

CommentFileSizeAuthor
#12 metatag-n3223289-12.patch4.31 KBdamienmckenna
#12 metatag-n3223289-12.interdiff.txt1.93 KBdamienmckenna
#10 metatag-n3223289-10.patch2.96 KBdamienmckenna
#8 metatag-n3223289-8.patch1.52 KBdamienmckenna

Issue fork metatag-3223289

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

DamienMcKenna created an issue. See original summary.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #3116138: Facebook catalog tags - product:retailer_item_id (D7) »
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Active

introfini made their first commit to this issue’s fork.

introfini opened merge request !25

introfini’s picture

introfini commented
Assigned: Unassigned » introfini
Status: Active » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: introfini » Unassigned
Parent issue: » #3203686: Plan for Metatag 8.x-1.17
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new metatag-n3223289-8.patch1.52 KB

With test coverage.

Status: Needs review » Needs work

The last submitted patch, 8: metatag-n3223289-8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n3223289-10.patch2.96 KB

The meta tag plugin needed to be renamed. I also noted it in the migration file.

Status: Needs review » Needs work

The last submitted patch, 10: metatag-n3223289-10.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
StatusFileSize
new metatag-n3223289-12.interdiff.txt1.93 KB
new metatag-n3223289-12.patch4.31 KB

I forgot about the schema change. And I misspelled the class name X-)

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Fixed

And the tests pass.

Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.